You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Call to the DigitalInputChange constructor (line 97) passes delay_time instead of interrupt_type as third parameter. Compiler silently casts the parameter but the button will not work.
API comments
Regarding DigitalInputChange:
interrupt_type seems redundant given the Class semantics implies only a CHANGE interrupt is applicable
Likewise config_path is unnecessary as there are no configurable parameters
I'm new to SensESP so my comments may be off the mark. Thank you for an outstanding project.
The text was updated successfully, but these errors were encountered:
Call to the
DigitalInputChange
constructor (line 97) passesdelay_time
instead ofinterrupt_type
as third parameter. Compiler silently casts the parameter but the button will not work.API comments
Regarding
DigitalInputChange
:interrupt_type
seems redundant given the Class semantics implies only aCHANGE
interrupt is applicableconfig_path
is unnecessary as there are no configurable parametersI'm new to SensESP so my comments may be off the mark. Thank you for an outstanding project.
The text was updated successfully, but these errors were encountered: