Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in examples/chain_counter.cpp #762

Open
smr547 opened this issue Oct 6, 2024 · 1 comment
Open

Bug in examples/chain_counter.cpp #762

smr547 opened this issue Oct 6, 2024 · 1 comment

Comments

@smr547
Copy link
Contributor

smr547 commented Oct 6, 2024

Call to the DigitalInputChange constructor (line 97) passes delay_time instead of interrupt_type as third parameter. Compiler silently casts the parameter but the button will not work.

API comments

Regarding DigitalInputChange:

  • interrupt_type seems redundant given the Class semantics implies only a CHANGE interrupt is applicable
  • Likewise config_path is unnecessary as there are no configurable parameters

I'm new to SensESP so my comments may be off the mark. Thank you for an outstanding project.

@kinyo666
Copy link

kinyo666 commented Dec 7, 2024

Duplicate of #623 Chain Counter Example uses DigitalInputChange() incorrectly (2022 !)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants