Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMB sentence specifies invalid keys #60

Open
panaaj opened this issue Nov 18, 2020 · 1 comment
Open

RMB sentence specifies invalid keys #60

panaaj opened this issue Nov 18, 2020 · 1 comment

Comments

@panaaj
Copy link
Member

panaaj commented Nov 18, 2020

RMB.js specifies the following keys..

sentence: 'RMB',
    title: 'RMB - Heading and distance to waypoint',
    keys: [
      'navigation.courseRhumbline.crossTrackError',
      'resources.waypoints.next.position.latitude',
      'resources.waypoints.next.position.longitude',
      'navigation.courseRhumbline.nextPoint.distance',
      'navigation.courseRhumbline.bearingTrue'
    ],
...

the keys resources.waypoints.next.position.latitude and resources.waypoints.next.position.longitude are not part of the spec.

I would suggest that these keys should be replaced with navigation.courseRhumbline.nextPoint.position.

Also the use of courseRhumbline vs courseGreatCircle should be reviewed for consistency across sentences (APB uses courseGreatCircle). Additionally signalk-derived-data plugin populates courseGreatCircle paths.

@dpazz
Copy link

dpazz commented Apr 30, 2023

I agree with you because the "resources..." starting path is unavailable in SignalK data browser and the RMB sentence is NEVER generated by the plugin. I'm trying to drive autopilot directly via SignalK. The XTE is correctly generated but not the APB or RMB, because of those unavailable "resources.." keys. In my case the APB is sent by an external nav app (AvNav) via an UDP writer to SignalK ad is correctly parsed and stored in SignalK data format in various keys. The next waypoint info is stored in the key "navigation.courseRhumbline.nextPoint" with two subkeys

{
"longitude": 10.21665,
"latitude": 43.76265
}

There's something to fix here in my humble opinion....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants