Skip to content
This repository has been archived by the owner on Aug 22, 2018. It is now read-only.

Multiple Assemblies (Reloaded) #466

Open
jason-wilmans opened this issue Sep 27, 2016 · 5 comments
Open

Multiple Assemblies (Reloaded) #466

jason-wilmans opened this issue Sep 27, 2016 · 5 comments
Labels

Comments

@jason-wilmans
Copy link

jason-wilmans commented Sep 27, 2016

This topic is similar to, but distinct from #390. I don't know how your policy on issue topics is, feel free to merge these two, or ask me to reopen the old one.

Tested Xenko Editor Studio Versions: 1.8.1 and 1.8.2

Steps to reproduce

  1. Start a new Xenko Project with default settings
  2. Add a second assembly with "Update Package > Add Code Library". (again default settings)
  3. Reference .MyLibrary from the .Windows assembly (which I forgot in issue Scripts from other Assemblies than the initial "<ProjectName>.Game" assembly fail to load in scene #390, but this time I double checked)
  4. Create an abstract script component "Parent" that inherits from, e.g. StartupScript (doesn't matter) in .MyLibrary
  5. Reference .MyLibrary from the .Game assembly
  6. Create a script that inherits from the Parent class, e.g. "Child"
  7. Add the "Child" Component to an entity in a prefab or scene.
  8. Build the project twice

Behavior

There are three types of errors, all seemingly related.

  1. Sometimes the serializer goes down, with the inner exception saying "Could not find parent serializer for type ThreeDee.MyLibrary.Child"
  2. Other times a seemingly related error occurs (exception details below) saying that the "Parent" type could not be loaded.
  3. This setup also tends to bring the whole editor down at points where (I assume) (de)serialization happens, e.g. project (re)load and component adding/removing.

Git Repo

The repository is the same as in the last issue (https://github.com/jason-wilmans/xenkoMultipleAssemblies.git). I tagged the commit with the current example '#466', the old one with '#390'.

exception2details.txt

@Kryptos-FR
Copy link

Thanks for the report. I could reproduce your issue.

Apparently the problem only occurs when a script inherits from another that is in a different code library. I could not reproduce if the derived script was in the same code library.

We will look into it and fix it in a future release.

@Kryptos-FR Kryptos-FR added the bug label Sep 28, 2016
@jason-wilmans
Copy link
Author

jason-wilmans commented Sep 28, 2016

Apparently the problem only occurs when a script inherits from another that is in a different code library

Yeah that was the behavior for me, too. Forgot to write that.

We will look into it and fix it in a future release

That's great! I really began to feel stupid, because I was thinking it was my error (because it was so close to the old issue). Looking forward :).

@stefnotch
Copy link

stefnotch commented Apr 10, 2018

@Kryptos-FR Has this issue been fixed? I think that #665 is related to this issue.

@Kryptos-FR
Copy link

@stefnotch I don't remember if it was. Better ask @xen2 .

@stefnotch
Copy link

@xen2 Has this issue been fixed? I think that #665 is related to this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants