Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling dismiss() should trigger onFinish call #500

Open
yizaho opened this issue Feb 10, 2025 · 0 comments
Open

Calling dismiss() should trigger onFinish call #500

yizaho opened this issue Feb 10, 2025 · 0 comments

Comments

@yizaho
Copy link

yizaho commented Feb 10, 2025

We would like to allow the user to finish the showcase at anytime by tapping a FloatingActionWidget close button.

When tapping this close button, we call dismiss, and the showcase appears to end, but onFinish is not called. It is important for onFinish to be called, since we have critical operations that need to be executed there (e.g. re-enabling taps/gestures).

Therefore, we would assume (hope) dismiss would also trigger onFinish.

We've tried using dismiss + next, but ids are null.

Currently, as a workaround, we are running a completed loop on the remaining keys, but this isn't ideal. It would be easier if dismiss() triggers onFinish.

@yizaho yizaho changed the title Calling dismiss() should trigger onFinish being called Calling dismiss() should trigger onFinish call Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant