Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for X.com links #438

Open
ayancey opened this issue Jul 15, 2024 · 5 comments
Open

Support for X.com links #438

ayancey opened this issue Jul 15, 2024 · 5 comments

Comments

@ayancey
Copy link

ayancey commented Jul 15, 2024

Twitter has almost completely migrated their domain to X.com. X.com links do not redirect through this extension over to Nitter.

@Yetangitu
Copy link

Apply this patch and run npm run build, copy/link/rename the resulting .zip to .xpi and install it in Firefox and it works again.

diff --git a/src/assets/javascripts/helpers/twitter.js b/src/assets/javascripts/helpers/twitter.js
index f520d76..e1fb1b0 100644
--- a/src/assets/javascripts/helpers/twitter.js
+++ b/src/assets/javascripts/helpers/twitter.js
@@ -5,8 +5,11 @@
   */
 const targets = [
   "twitter.com",
+  "x.com",
   "www.twitter.com",
+  "www.x.com",
   "mobile.twitter.com",
+  "mobile.x.com",
   "pbs.twimg.com",
   "video.twimg.com",
 ];

@edmael
Copy link

edmael commented Oct 8, 2024

Hey @Yetangitu, is there a reason why this is not in the main code?

@Kobayen
Copy link

Kobayen commented Oct 14, 2024

That makes the extension into an unsigned extension, and then it becomes unusable.

@Yetangitu
Copy link

Hey @Yetangitu, is there a reason why this is not in the main code?

I guess because the developer has not implemented it yet and nobody has made a PR for this change yet. I can submit it, maybe it gets picked up. Don't hold your breath though, there are loads of unmerged PRs for this extension.

@Yetangitu
Copy link

Yetangitu commented Oct 15, 2024

That makes the extension into an unsigned extension, and then it becomes unusable.

Nah, it works fine, it'll nag but since you know there reason for the nag there is no problem other than the occasional nag. You'll need to disable mandatory signature verification by setting xpinstall.signatures.required to false in about:config though. You still get warnings about unsigned extensions but you can run them.

image

Here's the PR: #440

Yetangitu pushed a commit to Yetangitu/privacy-redirect that referenced this issue Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants