-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for X.com links #438
Comments
Apply this patch and run diff --git a/src/assets/javascripts/helpers/twitter.js b/src/assets/javascripts/helpers/twitter.js
index f520d76..e1fb1b0 100644
--- a/src/assets/javascripts/helpers/twitter.js
+++ b/src/assets/javascripts/helpers/twitter.js
@@ -5,8 +5,11 @@
*/
const targets = [
"twitter.com",
+ "x.com",
"www.twitter.com",
+ "www.x.com",
"mobile.twitter.com",
+ "mobile.x.com",
"pbs.twimg.com",
"video.twimg.com",
]; |
Hey @Yetangitu, is there a reason why this is not in the main code? |
That makes the extension into an unsigned extension, and then it becomes unusable. |
I guess because the developer has not implemented it yet and nobody has made a PR for this change yet. I can submit it, maybe it gets picked up. Don't hold your breath though, there are loads of unmerged PRs for this extension. |
Nah, it works fine, it'll nag but since you know there reason for the nag there is no problem other than the occasional nag. You'll need to disable mandatory signature verification by setting Here's the PR: #440 |
Twitter has almost completely migrated their domain to X.com. X.com links do not redirect through this extension over to Nitter.
The text was updated successfully, but these errors were encountered: