Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge some/all of the zig improvements by liyu1981 #423

Open
SimonKagstrom opened this issue Mar 13, 2024 · 4 comments
Open

Merge some/all of the zig improvements by liyu1981 #423

SimonKagstrom opened this issue Mar 13, 2024 · 4 comments

Comments

@SimonKagstrom
Copy link
Owner

I.e., this fork:

https://github.com/liyu1981/kcov

@liyu1981, some input?

@liyu1981
Copy link

liyu1981 commented Mar 13, 2024

@SimonKagstrom I am glad that you find this work.

Currently the implementation of my hack is based on string comparison as from the semantics level I do not find good ways of doing that. I am not sure whether this is something kcov prefer, but I can prepare it in a pull request for discussion.

I have prepared #424 containing the core changes to kcov to support. We can discuss on top of that see whether it is a good way of adding zig support, or point me to the good way.

@SimonKagstrom
Copy link
Owner Author

I think the string comparison is fine. I guess probably other tools would do it that way as well.

The only real comment I have (see the PR) is that I think the comparison can be done in reporter.cc instead, and not in each writer, but feel free to try that out!

Thanks!

@PasVegan
Copy link

any update ? I see that the PR isn't merged.

@SimonKagstrom
Copy link
Owner Author

I think it's up to @liyu1981 to investigate and maybe fix what's left

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants