-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge some/all of the zig improvements by liyu1981 #423
Comments
@SimonKagstrom I am glad that you find this work. Currently the implementation of my hack is based on string comparison as from the semantics level I do not find good ways of doing that. I am not sure whether this is something I have prepared #424 containing the core changes to |
I think the string comparison is fine. I guess probably other tools would do it that way as well. The only real comment I have (see the PR) is that I think the comparison can be done in reporter.cc instead, and not in each writer, but feel free to try that out! Thanks! |
any update ? I see that the PR isn't merged. |
I think it's up to @liyu1981 to investigate and maybe fix what's left |
I.e., this fork:
https://github.com/liyu1981/kcov
@liyu1981, some input?
The text was updated successfully, but these errors were encountered: