Mirror: Suit slot weapon consistency + visuals (#247)

## Mirror of PR #26152: [Suit slot weapon consistency +
visuals](space-wizards/space-station-14#26152)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)

###### `6c239890c5c63c2e058fe9d7dfddcd36e25ca221`

PR opened by <img
src="https://avatars.githubusercontent.com/u/61917534?v=4"
width="16"/><a href="https://github.com/Vaaankas"> Vaaankas</a> at
2024-03-15 17:12:35 UTC

---

PR changed 84 files with 166 additions and 0 deletions.

The PR had the following labels:
- No C#
- Changes: Sprites


---

<details open="true"><summary><h1>Original Body</h1></summary>

> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
> 
> ## About the PR
> <!-- What did you change in this PR? -->
> 
> Changed weapons to be equippable in the suit slot where they weren't
for consistency.
> 
> Also copied visuals from the backpack and belt slots where appropriate
to the suit slot.
> 
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
> 
> It makes it easier to recognize when someone is armed and looks cool
with a lot of previously almost unused sprites being used.
> 
> A byproduct of #26116 discussion and feedback.
> 
> ## Technical details
> <!-- If this is a code change, summarize at high level how your new
code works. This makes it easier to review. -->
> 
> ## Media
> <!-- 
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
> 
> If you're unsure whether your PR will require media, ask a maintainer.
> 
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
> 
> - [+] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
> 
>
![Screenshot_27](https://github.com/space-wizards/space-station-14/assets/61917534/0eec7fea-b005-43a8-b505-c089b36794be)
>
![Screenshot_26](https://github.com/space-wizards/space-station-14/assets/61917534/74b2a277-ab08-4196-a847-202c21e1751e)
>
![Screenshot_25](https://github.com/space-wizards/space-station-14/assets/61917534/f7c6cb37-6e3b-4f83-b465-ef4ba9838d7c)
> 
> 
> ## Breaking changes
> <!--
> List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
> -->
> 
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
> 🆑 vanx
> - tweak: You can now wear most guns in the suit slot, and see them on
yourself!
> <!--
> Make sure to take this Changelog template out of the comment block in
order for it to show up.
> 🆑
> - add: Added fun!
> - remove: Removed fun!
> - tweak: Changed fun!
> - fix: Fixed fun!
> -->
> 


</details>

Co-authored-by: SimpleStation14 <Unknown>

Resources/Prototypes/Entities/Objects/Weapons/Guns/Battery/battery_guns.yml

@@ -84,6 +84,7 @@
     quickEquip: false
     slots:
     - Belt
+    - suitStorage
 
 - type: entity
   id: BaseWeaponPowerCellSmall

Resources/Prototypes/Entities/Objects/Weapons/Guns/Launchers/launchers.yml

@@ -33,6 +33,9 @@
         map: ["enum.GunVisualLayers.Base"]
   - type: Clothing
     sprite: Objects/Weapons/Guns/Launchers/china_lake.rsi
+    slots:
+    - Back
+    - suitStorage
   - type: AmmoCounter
   - type: Gun
     fireRate: 1

Resources/Prototypes/Entities/Objects/Weapons/Guns/Snipers/snipers.yml

@@ -16,6 +16,7 @@
     quickEquip: false
     slots:
     - Back
+    - suitStorage
   - type: AmmoCounter
   - type: Gun
     fireRate: 0.75

Resources/Prototypes/Entities/Objects/Weapons/Guns/flare_gun.yml

@@ -36,3 +36,4 @@
     quickEquip: false
     slots:
     - Belt
+    - suitStorage

Resources/Textures/Objects/Weapons/Guns/Basic/kinetic_accelerator.rsi/meta.json

@@ -38,6 +38,10 @@
         {
             "name": "equipped-BELT",
             "directions": 4
+        },
+		{
+            "name": "equipped-SUITSTORAGE",
+            "directions": 4
         }
     ]
 }

Resources/Textures/Objects/Weapons/Guns/Battery/advancedlasergun.rsi/meta.json

@@ -39,6 +39,10 @@
 		{
 			"name": "equipped-BELT",
 			"directions": 4
+		},
+		{
+			"name": "equipped-SUITSTORAGE",
+			"directions": 4
 		}
     ]
 }

Resources/Textures/Objects/Weapons/Guns/Battery/antiquelasergun.rsi/meta.json

@@ -71,6 +71,10 @@
 		{
 			"name": "equipped-BELT",
 			"directions": 4
+		},
+		{
+			"name": "equipped-SUITSTORAGE",
+			"directions": 4
 		}
 	]
 }

Resources/Textures/Objects/Weapons/Guns/Battery/disabler.rsi/meta.json

@@ -72,6 +72,10 @@
 		{
 			"name": "equipped-BELT",
 			"directions": 4
+		},
+		{
+			"name": "equipped-SUITSTORAGE",
+			"directions": 4
 		}
     ]
 }

Resources/Textures/Objects/Weapons/Guns/Battery/laser_cannon.rsi/meta.json

@@ -68,6 +68,10 @@
     {
       "name": "equipped-BACKPACK",
       "directions": 4
+    },
+	{
+      "name": "equipped-SUITSTORAGE",
+      "directions": 4
     }
 	]
 }

Resources/Textures/Objects/Weapons/Guns/Battery/laser_gun.rsi/meta.json

@@ -36,6 +36,10 @@
     {
       "name": "equipped-BACKPACK",
       "directions": 4
+    },
+	{
+      "name": "equipped-SUITSTORAGE",
+      "directions": 4
     }
     ]
 }

Resources/Textures/Objects/Weapons/Guns/Battery/makeshift.rsi/meta.json

@@ -36,6 +36,10 @@
     {
       "name": "equipped-BACKPACK",
       "directions": 4
+    },
+	{
+      "name": "equipped-SUITSTORAGE",
+      "directions": 4
     },
 	{
 	  "name": "equipped-BELT",

Resources/Textures/Objects/Weapons/Guns/Battery/practice_disabler.rsi/meta.json

@@ -64,6 +64,10 @@
 		{
 			"name": "equipped-BELT",
 			"directions": 4
+		},
+		{
+			"name": "equipped-SUITSTORAGE",
+			"directions": 4
 		}
     ]
 }

Resources/Textures/Objects/Weapons/Guns/Battery/pulse_carbine.rsi/meta.json

@@ -36,6 +36,10 @@
     {
       "name": "equipped-BACKPACK",
       "directions": 4
+    },
+	{
+      "name": "equipped-SUITSTORAGE",
+      "directions": 4
     }
     ]
 }

Resources/Textures/Objects/Weapons/Guns/Battery/pulse_rifle.rsi/meta.json

@@ -36,6 +36,10 @@
     {
       "name": "equipped-BACKPACK",
       "directions": 4
+    },
+	{
+      "name": "equipped-SUITSTORAGE",
+      "directions": 4
     }
     ]
 }

Resources/Textures/Objects/Weapons/Guns/Battery/taser.rsi/meta.json

@@ -77,6 +77,10 @@
     {
       "name": "equipped-BELT",
       "directions": 4
+    },
+	{
+      "name": "equipped-SUITSTORAGE",
+      "directions": 4
     }
   ]
 }

Resources/Textures/Objects/Weapons/Guns/Battery/xray.rsi/meta.json

@@ -45,6 +45,10 @@
     {
       "name": "equipped-BACKPACK",
       "directions": 4
+    },
+	{
+      "name": "equipped-SUITSTORAGE",
+      "directions": 4
     }
   ]
 }

Resources/Textures/Objects/Weapons/Guns/Launchers/china_lake.rsi/meta.json

@@ -24,6 +24,10 @@
         {
             "name": "equipped-BACKPACK",
             "directions": 4
+        },
+		{
+            "name": "equipped-SUITSTORAGE",
+            "directions": 4
         }
     ]
 }

Resources/Textures/Objects/Weapons/Guns/Pistols/N1984.rsi/meta.json

@@ -30,6 +30,10 @@
         {
             "name": "equipped-BELT",
             "directions": 4
+        },
+		{
+            "name": "equipped-SUITSTORAGE",
+            "directions": 4
         }
     ]
 }

Resources/Textures/Objects/Weapons/Guns/Pistols/cobra.rsi/meta.json

@@ -27,6 +27,10 @@
         {
             "name": "equipped-BELT",
             "directions": 4
+        },
+		{
+            "name": "equipped-SUITSTORAGE",
+            "directions": 4
         }
     ]
 }

Resources/Textures/Objects/Weapons/Guns/Pistols/mk58.rsi/meta.json

@@ -30,6 +30,10 @@
         {
             "name": "equipped-BELT",
             "directions": 4
+        },
+		{
+            "name": "equipped-SUITSTORAGE",
+            "directions": 4
         }
     ]
 }

Resources/Textures/Objects/Weapons/Guns/Pistols/viper.rsi/meta.json

@@ -33,6 +33,10 @@
         {
             "name": "equipped-BELT",
             "directions": 4
+        },
+		{
+            "name": "equipped-SUITSTORAGE",
+            "directions": 4
         }
     ]
 }

Resources/Textures/Objects/Weapons/Guns/Revolvers/chimp.rsi/meta.json

@@ -27,6 +27,10 @@
 	{
 	  "name": "equipped-BELT",
 	  "directions": 4
+	},
+	{
+	  "name": "equipped-SUITSTORAGE",
+	  "directions": 4
 	}
   ]
 }

Resources/Textures/Objects/Weapons/Guns/Revolvers/deckard.rsi/meta.json

@@ -33,6 +33,10 @@
 	{
 	  "name": "equipped-BELT",
 	  "directions": 4
+	},
+	{
+	  "name": "equipped-SUITSTORAGE",
+	  "directions": 4
 	}
   ]
 }

Resources/Textures/Objects/Weapons/Guns/Revolvers/inspector.rsi/meta.json

@@ -24,6 +24,10 @@
         {
             "name": "equipped-BELT",
             "directions": 4
+        },
+		{
+            "name": "equipped-SUITSTORAGE",
+            "directions": 4
         }
     ]
 }

Resources/Textures/Objects/Weapons/Guns/Revolvers/mateba.rsi/meta.json

@@ -24,6 +24,10 @@
         {
             "name": "equipped-BELT",
             "directions": 4
+        },
+		{
+            "name": "equipped-SUITSTORAGE",
+            "directions": 4
         }
     ]
 }

Resources/Textures/Objects/Weapons/Guns/Revolvers/pirate_revolver.rsi/meta.json

@@ -24,6 +24,10 @@
         {
             "name": "equipped-BELT",
             "directions": 4
+        },
+		{
+            "name": "equipped-SUITSTORAGE",
+            "directions": 4
         }
     ]
 }

Resources/Textures/Objects/Weapons/Guns/Rifles/ak.rsi/meta.json

@@ -30,6 +30,10 @@
         {
             "name": "equipped-BACKPACK",
             "directions": 4
+		},
+		{
+			"name": "equipped-SUITSTORAGE",
+			"directions": 4
         }
     ]
 }

Resources/Textures/Objects/Weapons/Guns/Rifles/carbine.rsi/meta.json

@@ -30,6 +30,10 @@
         {
             "name": "equipped-BACKPACK",
             "directions": 4
+        },
+		{
+            "name": "equipped-SUITSTORAGE",
+            "directions": 4
         }
     ]
 }

Resources/Textures/Objects/Weapons/Guns/Rifles/lecter.rsi/meta.json

@@ -30,6 +30,10 @@
         {
             "name": "equipped-BACKPACK",
             "directions": 4
+        },
+		{
+            "name": "equipped-SUITSTORAGE",
+            "directions": 4
         }
     ]
 }

Resources/Textures/Objects/Weapons/Guns/SMGs/atreides.rsi/meta.json

@@ -33,6 +33,10 @@
         {
             "name": "equipped-BACKPACK",
             "directions": 4
+        },
+		{
+            "name": "equipped-SUITSTORAGE",
+            "directions": 4
         }
     ]
 }

Resources/Textures/Objects/Weapons/Guns/SMGs/c20r.rsi/meta.json

@@ -48,6 +48,10 @@
         {
             "name": "equipped-BACKPACK",
             "directions": 4
+        },
+		{
+            "name": "equipped-SUITSTORAGE",
+            "directions": 4
         }
     ]
 }

Resources/Textures/Objects/Weapons/Guns/SMGs/drozd.rsi/meta.json

@@ -33,6 +33,10 @@
     {
       "name": "equipped-BACKPACK",
       "directions": 4
+    },
+	{
+      "name": "equipped-SUITSTORAGE",
+      "directions": 4
     }
     ]
 }

Resources/Textures/Objects/Weapons/Guns/SMGs/vector.rsi/meta.json

@@ -30,6 +30,10 @@
         {
             "name": "equipped-BACKPACK",
             "directions": 4
+        },
+		{
+            "name": "equipped-SUITSTORAGE",
+            "directions": 4
         }
     ]
 }

Resources/Textures/Objects/Weapons/Guns/SMGs/wt550.rsi/meta.json

@@ -147,6 +147,10 @@
     {
       "name": "equipped-BACKPACK",
       "directions": 4
+    },
+	{
+      "name": "equipped-SUITSTORAGE",
+      "directions": 4
     }
   ]
 }

Resources/Textures/Objects/Weapons/Guns/Shotguns/bulldog.rsi/meta.json

@@ -30,6 +30,10 @@
         {
             "name": "equipped-BACKPACK",
             "directions": 4
+        },
+		{
+            "name": "equipped-SUITSTORAGE",
+            "directions": 4
         }
     ]
 }

Resources/Textures/Objects/Weapons/Guns/Shotguns/db_shotgun.rsi/meta.json

@@ -16,6 +16,10 @@
         {
             "name": "equipped-BACKPACK",
             "directions": 4
+        },
+		{
+            "name": "equipped-SUITSTORAGE",
+            "directions": 4
         }
     ]
 }

Resources/Textures/Objects/Weapons/Guns/Shotguns/enforcer.rsi/meta.json

@@ -16,6 +16,10 @@
         {
             "name": "equipped-BACKPACK",
             "directions": 4
+        },
+		{
+            "name": "equipped-SUITSTORAGE",
+            "directions": 4
         }
     ]
 }