From 70f527ac2e9180317a0cfa58e47638db160e351a Mon Sep 17 00:00:00 2001 From: SimpleStation14 <130339894+SimpleStation14@users.noreply.github.com> Date: Fri, 10 May 2024 18:18:46 -0700 Subject: [PATCH] Mirror: Atmospherics thermomachines now properly excite the gas mixture they add heat to (#119) ## Mirror of PR #25916: [Atmospherics thermomachines now properly excite the gas mixture they add heat to](https://github.com/space-wizards/space-station-14/pull/25916) from space-wizards [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `1e62e445f0b5298c50dc0ab7ff20f88563a13d5f` PR opened by Menshin at 2024-03-07 20:16:52 UTC PR merged by web-flow at 2024-03-07 21:05:43 UTC --- PR changed 1 files with 2 additions and 2 deletions. The PR had the following labels: - Status: Needs Review ---

Original Body

> > > > ## About the PR > > Atmospherics thermomachines now properly invalidate the tile they are exchanging heat with. > Fixes #25827. > > ## Technical details > > Atmospherics thermomachines were retrieving the gas mixture from the tile they were on without invalidating the tile, so no atmos update was done apart from the temperature of the tile gas mixture rising. They now do so. > > Note that this was affecting hellfire heater/freezer too. > > > ## Media > > > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > **Changelog** > > Not needed i think > >
Co-authored-by: Menshin --- .../Piping/Unary/EntitySystems/GasThermoMachineSystem.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Content.Server/Atmos/Piping/Unary/EntitySystems/GasThermoMachineSystem.cs b/Content.Server/Atmos/Piping/Unary/EntitySystems/GasThermoMachineSystem.cs index d376c6d9d6e..d4ddd65a8ec 100644 --- a/Content.Server/Atmos/Piping/Unary/EntitySystems/GasThermoMachineSystem.cs +++ b/Content.Server/Atmos/Piping/Unary/EntitySystems/GasThermoMachineSystem.cs @@ -110,7 +110,7 @@ private void OnThermoMachineUpdated(EntityUid uid, GasThermoMachineComponent the _atmosphereSystem.AddHeat(heatExchangeGasMixture, dQPipe); thermoMachine.LastEnergyDelta = dQPipe; - if (dQLeak != 0f && _atmosphereSystem.GetContainingMixture(uid) is { } containingMixture) + if (dQLeak != 0f && _atmosphereSystem.GetContainingMixture(uid, excite: true) is { } containingMixture) _atmosphereSystem.AddHeat(containingMixture, dQLeak); } @@ -126,7 +126,7 @@ private void GetHeatExchangeGasMixture(EntityUid uid, GasThermoMachineComponent heatExchangeGasMixture = null; if (thermoMachine.Atmospheric) { - heatExchangeGasMixture = _atmosphereSystem.GetContainingMixture(uid); + heatExchangeGasMixture = _atmosphereSystem.GetContainingMixture(uid, excite: true); } else {