From 98d39ca52cec7fbff9dc8d374def9ef461971365 Mon Sep 17 00:00:00 2001 From: Mnemotechnican <69920617+Mnemotechnician@users.noreply.github.com> Date: Fri, 12 Jul 2024 20:46:37 +0300 Subject: [PATCH] Foreigner Minor Fixes (#542) # Description #525 Added foreigner traits, now during testing I revealed a few bugs. This PR fixes them: - The light version now correctly allows you to understand common (it would not because I forgot to add [DataField]) - The translator now correctly starts with a high-capacity power cell - Equipping the translator in a pocket slot no longer takes time

Media

![image](https://github.com/user-attachments/assets/4d2cabc7-2ce2-498b-822b-8ff9b82eea7d)

# Changelog :cl: - fix: Foreigner traits now work correctly. --- Content.Server/Traits/Assorted/ForeignerTraitComponent.cs | 2 ++ Resources/Prototypes/Entities/Objects/Devices/translators.yml | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Content.Server/Traits/Assorted/ForeignerTraitComponent.cs b/Content.Server/Traits/Assorted/ForeignerTraitComponent.cs index e2d74ba5d9b..756f44e7429 100644 --- a/Content.Server/Traits/Assorted/ForeignerTraitComponent.cs +++ b/Content.Server/Traits/Assorted/ForeignerTraitComponent.cs @@ -21,11 +21,13 @@ public sealed partial class ForeignerTraitComponent : Component /// /// Whether this trait prevents the entity from understanding the base language. /// + [DataField] public bool CantUnderstand = true; /// /// Whether this trait prevents the entity from speaking the base language. /// + [DataField] public bool CantSpeak = true; /// diff --git a/Resources/Prototypes/Entities/Objects/Devices/translators.yml b/Resources/Prototypes/Entities/Objects/Devices/translators.yml index b28541253d4..2eb44264548 100644 --- a/Resources/Prototypes/Entities/Objects/Devices/translators.yml +++ b/Resources/Prototypes/Entities/Objects/Devices/translators.yml @@ -24,7 +24,7 @@ - type: HandheldTranslator enabled: false - type: Clothing # To allow equipping translators on the neck slot - slots: [neck, pocket] + slots: [neck] equipDelay: 0.3 unequipDelay: 0.3 quickEquip: false # Would conflict @@ -52,7 +52,7 @@ - type: entity noSpawn: true id: TranslatorForeigner - parent: [ Translator, PowerCellSlotHighItem ] + parent: [ TranslatorUnpowered, PowerCellSlotHighItem ] name: foreigner's translator description: A special-issue translator that helps foreigner's speak and understand this station's primary language.