Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weight and Height need calibration. #497

Closed
DangerRevolution opened this issue Jun 30, 2024 · 1 comment
Closed

Weight and Height need calibration. #497

DangerRevolution opened this issue Jun 30, 2024 · 1 comment
Labels
Priority: 4-Low Should be resolved at some point Size: 4-Small For small issues/PRs Status: Needs Discussion Must be discussed

Comments

@DangerRevolution
Copy link
Contributor

Description

Title. Calibration is needed to reign in wacky designs; (primarily that width slider) from making pencil-thin characters that are mega-squashed.
@DangerRevolution DangerRevolution added Priority: 4-Low Should be resolved at some point Size: 4-Small For small issues/PRs Status: Needs Discussion Must be discussed labels Jun 30, 2024
@Mnemotechnician
Copy link
Contributor

Agreed, the aspect ratio of characters should be restricted to something in some range like 0.7-1.3. I.e. the minimum/maximum width of a character should depend on their current height.

@Aidenkrz Aidenkrz mentioned this issue Oct 15, 2024
Merged
VMSolidus added a commit that referenced this issue Oct 16, 2024
@Aidenkrz @VMSolidus @DEATHB4DEFEAT
Constrict Height and Width via a Size Ratio & Fix Humanoids Not Havin…
0865e47 
…g A Fixture (#1049)

# Description

Title
Intended to stop players from making slender men type characters with
height maxed and width at the minimum, and vice versa
The ratio can be modified via the species' prototype

Also fixes the issue of players being able to noclip because they're
fixture has no radius by setting the Height and Width to the species
default if none is provided. (technically this also fixes Urists always
being as small as possible)

Solves #865 #497
Partially resolves #995

---

<details><summary><h1>Media</h1></summary>
<p>


https://github.com/user-attachments/assets/1b3b32f1-5976-41f8-935b-7d53106e5452

</p>
</details>

---

# Changelog

:cl:
- tweak: Height and width are now constrained by each other.
- fix: Humanoids can no longer phase through walls.

---------

Signed-off-by: Aiden <[email protected]>
Co-authored-by: VMSolidus <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: 4-Low Should be resolved at some point Size: 4-Small For small issues/PRs Status: Needs Discussion Must be discussed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@VMSolidus @Mnemotechnician @DangerRevolution