Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror: Atmospherics thermomachines now properly excite the gas mixture they add heat to #119

Merged
merged 1 commit into from
May 11, 2024
Merged

Mirror: Atmospherics thermomachines now properly excite the gas mixture they add heat to #119

merged 1 commit into from
May 11, 2024

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #25916: Atmospherics thermomachines now properly excite the gas mixture they add heat to from space-wizards space-wizards/space-station-14

1e62e445f0b5298c50dc0ab7ff20f88563a13d5f

PR opened by Menshin at 2024-03-07 20:16:52 UTC
PR merged by web-flow at 2024-03-07 21:05:43 UTC

PR changed 1 files with 2 additions and 2 deletions.

The PR had the following labels:

  • Status: Needs Review

Original Body

About the PR

Atmospherics thermomachines now properly invalidate the tile they are exchanging heat with.
Fixes #25827.

Technical details

Atmospherics thermomachines were retrieving the gas mixture from the tile they were on without invalidating the tile, so no atmos update was done apart from the temperature of the tile gas mixture rising. They now do so.

Note that this was affecting hellfire heater/freezer too.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
    Changelog

Not needed i think

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 21, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:14
@VMSolidus VMSolidus marked this pull request as ready for review May 4, 2024 23:10
@VMSolidus VMSolidus enabled auto-merge (squash) May 4, 2024 23:28
@VMSolidus VMSolidus disabled auto-merge May 4, 2024 23:29
@DangerRevolution DangerRevolution enabled auto-merge (squash) May 11, 2024 01:18
DangerRevolution
DangerRevolution approved these changes May 11, 2024
View reviewed changes
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@DangerRevolution DangerRevolution merged commit 70f527a into Simple-Station:master May 11, 2024
20 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
@FoxxoTrystan
Merge pull request Simple-Station#119 from Memeji/Clothing---Nikko
8f0216c 
Clothing-Nikko
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
@Floof-Station-Bot
Automatic Changelog Update (Simple-Station#119)
83162d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VMSolidus VMSolidus VMSolidus approved these changes

@DangerRevolution DangerRevolution DangerRevolution approved these changes

Assignees
No one assigned
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SimpleStation14 @VMSolidus @DangerRevolution @Menshin