Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: fix: ambient music fade in (#25874) #137

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #25969: fix: ambient music fade in (#25874) from space-wizards space-wizards/space-station-14

e47f84568eec53efd66fca6e79d8c594a508cf3c

PR opened by Kokoc9n at 2024-03-10 16:26:28 UTC
PR merged by web-flow at 2024-03-10 17:08:05 UTC


PR changed 1 files with 3 additions and 3 deletions.

The PR had the following labels:


Original Body

About the PR

Ambient music volume now set to ambient music volume slider.

Why / Balance

Space ambience tracks being super loud #25874.

Technical details

FadeIn and UpdateFades now get correct values instead of blasting music on maximum volume.

Media

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 21, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@VMSolidus VMSolidus marked this pull request as ready for review May 4, 2024 23:21
@VMSolidus VMSolidus enabled auto-merge (squash) May 4, 2024 23:43
@VMSolidus VMSolidus merged commit f14800a into Simple-Station:master May 4, 2024
20 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants