Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror: Fix misprediction of emergency access #139

Merged
merged 1 commit into from
May 4, 2024
Merged

Mirror: Fix misprediction of emergency access #139

merged 1 commit into from
May 4, 2024

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #25973: Fix misprediction of emergency access from space-wizards space-wizards/space-station-14

deac5a6842a88944b06c0b4d75da751880ddf12b

PR opened by nikthechampiongr at 2024-03-10 18:09:35 UTC
PR merged by web-flow at 2024-03-11 01:50:09 UTC

PR changed 2 files with 2 additions and 1 deletions.

The PR had the following labels:

Original Body

fixes #25800
fixes #25900

About the PR

The client now actually knows when an airlock is in emergency access.

Technical details

The EmergencyAccess bool was not getting synced to the client. Made it AutoNetworked. Also dirtied the airlock component on the function that actually sets it since it's only called on the server when you use a remote and as such doesn't sync to the client otherwise.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

no cl no fun

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 21, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@VMSolidus VMSolidus marked this pull request as ready for review May 4, 2024 23:13
@VMSolidus VMSolidus enabled auto-merge (squash) May 4, 2024 23:35
@VMSolidus VMSolidus merged commit 3fcc530 into Simple-Station:master May 4, 2024
20 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
@FoxxoTrystan
Merge pull request Simple-Station#139 from Memeji/Nikko--Toybox
6b67a56 
Couch and Stripper Pole!
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
@Floof-Station-Bot
Automatic Changelog Update (Simple-Station#139)
2f87d8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VMSolidus VMSolidus VMSolidus approved these changes

@DangerRevolution DangerRevolution DangerRevolution approved these changes

Assignees
No one assigned
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SimpleStation14 @VMSolidus @DangerRevolution @nikthechampiongr