Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Fix arrivals not docking on spinning stations #158

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26033: Fix arrivals not docking on spinning stations from space-wizards space-wizards/space-station-14

9e2e51431938b2df9391939fe499f8963b297292

PR opened by ShadowCommander at 2024-03-12 09:44:08 UTC
PR merged by web-flow at 2024-03-12 12:57:35 UTC


PR changed 1 files with 1 additions and 1 deletions.

The PR had the following labels:

  • Issue: Bug
  • Size: Very Small

Original Body

About the PR

Angle tolerance was too tight for the arrivals shuttle to dock on station when it was spinning.

Changed the tolerance from 0.01 to 0.15.

Fixes #25901

Why / Balance

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • fix: Fixed arrivals shuttle not docking with the station when it was slowly spinning.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 21, 2024
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not an issue for us, but if a fork wants to re-enable arrivals this would be worth happening

@VMSolidus
Copy link
Member

image
Tests pass on localhost.

@VMSolidus VMSolidus merged commit 035524b into Simple-Station:master Apr 30, 2024
11 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants