Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Remove random Cyrillic characters from locale files #159

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26043: Remove random Cyrillic characters from locale files from space-wizards space-wizards/space-station-14

ffd52b24ff9bbe33eab30aec1b19d4c1fbb05245

PR opened by arimah at 2024-03-12 15:52:06 UTC
PR merged by web-flow at 2024-03-12 15:58:04 UTC


PR changed 2 files with 2 additions and 2 deletions.

The PR had the following labels:

  • No C#

Original Body

About the PR

While playing around with the game's data, I discovered 'cocoa powder' got sorted after all the other reagents. I poked around for a minute, and what do you know, that first letter isn't a c, it's actually the Cyrillic lowercase letter с! I searched all .yml and .ftl files for more Cyrillic, and found exactly one other occurrence. This PR fixes both.

Why / Balance

Correctness. For one, you currently can't find cocoa powder or anything that uses it in the guidebook by searching "cocoa powder". :D

Technical details

.ftl

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

god I hope not

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 21, 2024
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't see the difference but github does 🤷

@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@VMSolidus VMSolidus marked this pull request as ready for review May 6, 2024 18:49
@VMSolidus VMSolidus merged commit 07692c4 into Simple-Station:master May 9, 2024
18 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants