Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Nuke Music start adjusted for duration #163

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #25946: Nuke Music start adjusted for duration from space-wizards space-wizards/space-station-14

680cf5fec13b92f09355acec9892f2db51f3e80e

PR opened by Errant-4 at 2024-03-09 18:24:36 UTC
PR merged by web-flow at 2024-03-12 18:50:34 UTC


PR changed 2 files with 16 additions and 5 deletions.

The PR had the following labels:


Original Body

About the PR

Nuke Music now begins playing at the appropriate time to end just-on-target regardless of the duration of the music (as long as it's less than 290 seconds)

fixes #25775

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 21, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@VMSolidus VMSolidus marked this pull request as ready for review May 5, 2024 00:46
@VMSolidus VMSolidus merged commit 883ded1 into Simple-Station:master May 9, 2024
20 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants