Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror: Contraband Storage Crate #181

Merged
merged 1 commit into from
May 9, 2024
Merged

Mirror: Contraband Storage Crate #181

merged 1 commit into from
May 9, 2024

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #25974: Contraband Storage Crate from space-wizards space-wizards/space-station-14

49c819373919d6ad2c7e1d802025782ecdce370b

PR opened by PursuitInAshes at 2024-03-10 18:12:13 UTC

PR changed 1 files with 12 additions and 0 deletions.

The PR had the following labels:

  • No C#

Original Body

About the PR

Adds a Contraband Storage Crate for the armory. This can be used by mappers to provide better and more suitable storage then an empty rack.

Why / Balance

Dumping items that were confiscated from the syndicate on the ground or in exposed racks felt wrong and unfitting for more stations. This provides an armory locked crate to fill that purpose.

Media

Content Client_JYZIEQmEgm

Changelog

No CL, not really player facing.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
DangerRevolution
DangerRevolution suggested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have a locker too for variability + Delta uses lockers for this purpose

@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@VMSolidus
Copy link
Member

should have a locker too for variability + Delta uses lockers for this purpose

That really should be a separate PR to be honest. Also this is a required Mirror for the DeltaV pile it seems.

@VMSolidus VMSolidus marked this pull request as ready for review May 6, 2024 18:40
DangerRevolution
DangerRevolution approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a locker one day

@VMSolidus VMSolidus merged commit 78e1541 into Simple-Station:master May 9, 2024
20 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 14, 2024
@Fansana
Merge pull request Simple-Station#181 from Mnemotechnician/fix/floof-…
fc72009 
…hotifx-requirements

Cherry-Pick "Fix Logic Requirements Not Checking Inversion"
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 14, 2024
@Floof-Station-Bot
Automatic Changelog Update (Simple-Station#181)
2dedcab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VMSolidus VMSolidus VMSolidus approved these changes

@DangerRevolution DangerRevolution DangerRevolution approved these changes

Assignees
No one assigned
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimpleStation14 @VMSolidus @DangerRevolution