Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FalseAlarmRule #587

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Fix FalseAlarmRule #587

merged 1 commit into from
Jul 24, 2024

Conversation

Mnemotechnician
Copy link
Contributor

Description

Grrr, 3 lines changed. Filter out events that don't have a start announcement.

Changelog

🆑

  • fix: False alarm event will no longer report events that should not be reported.

@github-actions github-actions bot added the Changes: C# Changes any cs files label Jul 24, 2024
VMSolidus
VMSolidus approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, no more impossible alerts.

@DEATHB4DEFEAT DEATHB4DEFEAT merged commit 527acd8 into Simple-Station:master Jul 24, 2024
12 checks passed
@DEATHB4DEFEAT DEATHB4DEFEAT added the Size: 5-Very Small For especially small issues/PRs label Jul 24, 2024
SimpleStation14 added a commit that referenced this pull request Jul 24, 2024
@SimpleStation14
Automatic Changelog Update (#587)
6afac54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DEATHB4DEFEAT DEATHB4DEFEAT DEATHB4DEFEAT approved these changes

@VMSolidus VMSolidus VMSolidus approved these changes

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Size: 5-Very Small For especially small issues/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mnemotechnician @VMSolidus @DEATHB4DEFEAT