Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port Justice Department From DeltaV #675

Merged
merged 9 commits into from
Aug 6, 2024
Merged

Port Justice Department From DeltaV #675

merged 9 commits into from
Aug 6, 2024

Conversation

VMSolidus
Copy link
Member

Description

This ports DeltaV-Station/Delta-v#660

About the PR

Adds the Justice Department, a department enveloping the lawyer and 3 new roles that manage the court system and charges against the accused. Includes: • New department, Justice! • 3 new roles: ◦ Chief Justice: The main, impartial judge for the station responsible for adjudicating criminal and civil trials, as well as other small matters like paroles and pardons. ◦ Clerk: The court clerk, who organizes trials, notarizes court documents (warrants, sentences, etc), and ensures correct sentencing and due process for the accused in sec custody. ◦ Prosecutor: A special lawyer role that legally advises sec and handles all of its court prep and prosecution, freeing up sec's time to go stun baton the clown instead of waiting for trial. • Antag objective to steal the Clerk's notary stamp, an object imbued with the authority to officialize court decisions. • Made the Lawyer role easier to understand and added them to the department. Renamed to Attorney, they now exclusively defend the accused or can sue on their behalf. Can also curse at the prosecutor in the bar. • Changed SoP to match. Notable changes include ◦ Felony charges and above must be reviewed and approved by the Clerk or Chief Justice if those roles are active. ◦ Parole, criminal trials, and civil trials are now all adjudicated by the Chief Justice, or the clerk in their absence. ◦ To ensure fair judgement, a Captain can only remove the Chief Justice with a majority vote from command. ◦ Warrants and court decisions must be written down and stamped with the notary stamp. Warrants must be approved by the Chief Justice. ◦ Full list of SoP changes can be found here: https://docs.google.com/document/d/12ZKTtzvVWBuC7PuiREL9v7mhVZve11p0-T6MBPpVeGs/edit?usp=sharing • Classy wooden desk timer to help keep trials timely and within limits.

TO DO: Chief Justice

  • Role
  • Inventory
  • Job Description
  • Icon
  • Access (CMD/CJ/Sec/Justice*)
  • Airlocks
  • Spawnpoint
  • Closet(just reuse legal w/ a lock)
  • Gavel** (proto/sprite/sound)
  • Stamp (proto/sprite)
  • Drip

Court Clerk

  • Role
  • Inventory
  • Job Description
  • Icon
  • Access (Sec/Justice*)
  • Spawnpoint
  • Closet(just reuse legal w/ a lock)
  • Stamp** (proto/sprite)
  • Warrant document
  • Drip

Prosecutor

  • Role
  • Inventory
  • Job Description
  • Icon
  • Access (Sec/Justice*)
  • Spawnpoint
  • Closet(just reuse legal w/ a lock)
  • Drip(Can be same as lawyer but should have a unique badge)

SoP/Guidlines

  • Civil and criminal law-penalties
  • Legal mutiny?
  • Assigning judges when no judge is present
  • Judge is representative of CC. Not necessarily above captain but outside.
  • When to appeal to a jury? How to pick a jury? (random would be good)
  • Rules for gaining warrants
  • Procedure for arresting officer filing criminal charges
  • Rules for summoning witnesses
  • Guide/book

Other

  • Station Beacons

Notes:

  • We might want to consider bringing back brig access for cells to give legal dept sec access and not control over prisoners.
  • Mapping would need to provide offices for CJ, CC, and Prosecuter.
  • Chief Justice is a rep of CC not necessarily above captain but outside

Why / Balance

The current legal system in-game is built around LRP gameplay, with security handling everything relating to arrests, sentencing, trials, and execution. Additionally, it is near-impossible to find an impartial judge for any court case with the current system. New legal department would guarantee an impartial and available judge (whether it be the Chief Justice or Clerk) for any court case, take pressure off of security to handle things like sentencing and trials. Additionally, there will be more roleplay opportunities for things like civil cases, inter-department disputes, internal affairs, or whatever else you may need legal help with.

Technical details

n/a

Media

image image

  • I have added screenshots/videos to this PR showcasing its changes in-game, or this PR does not require an in-game showcase

Breaking changes

none that I know of 😓

Changelog 🆑 Leo, Velcroboy, and Timemaster

  • add: Added The Justice Department >:)

@github-actions github-actions bot added Changes: Audio Changes any ogg files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files labels Aug 5, 2024
@VMSolidus VMSolidus added Priority: 3-Medium Needs to be resolved at some point Status: Needs Cleanup Someone has to clean this before merging Status: Do Not Merge Do not merge Size: 1-Very Large For especially large issues/PRs and removed Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: Audio Changes any ogg files labels Aug 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024 •
edited
Loading

RSI Diff Bot; head commit 0a50c5d merging into 4a6ad8c
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Clothing/Ears/Headsets/justice.rsi

State Old New Status
alt-equipped-EARS Added
equipped-EARS Added
icon Added
icon_alt Added

Resources/Textures/DeltaV/Clothing/Head/Hats/cj_toque.rsi

State Old New Status
equipped-HELMET Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/Neck/Cloaks/cjcloak.rsi

State Old New Status
equipped-NECK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/Neck/Misc/prosecutorbadge.rsi

State Old New Status
equipped-NECK Added
icon Added

Resources/Textures/DeltaV/Clothing/Neck/mantles/cjmantle.rsi

State Old New Status
equipped-NECK Added
icon Added

Resources/Textures/DeltaV/Clothing/OuterClothing/Coats/cjrobe.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/OuterClothing/Vests/clerkvest.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/cj.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/clerk.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/prosecutorred.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpsuit/cj.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpsuit/cj_white.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpsuit/cjformal.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpsuit/clerk.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpsuit/prosecutorred.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Interface/Misc/job_icons.rsi

State Old New Status
ChiefJustice Added
Clerk Added
Lawyer Added
Prosecutor Added

Resources/Textures/DeltaV/Markers/jobs.rsi

State Old New Status
chiefjustice Added
clerk Added
prosecutor Added

Resources/Textures/DeltaV/Objects/Devices/encryption_keys.rsi

State Old New Status
justice_label Added

Resources/Textures/DeltaV/Objects/Devices/pda.rsi

State Old New Status
pda-chiefjustice Added
pda-clerk Added
pda-prosecutor Added

Resources/Textures/DeltaV/Objects/Misc/stamps.rsi

State Old New Status
stamp-cj Added
stamp-notary Added

Resources/Textures/DeltaV/Objects/Specific/Justice/gavel.rsi

State Old New Status
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Objects/Specific/Justice/gavelblock.rsi

State Old New Status
icon Added

Resources/Textures/DeltaV/Objects/Specific/Justice/trialtimer.rsi

State Old New Status
trialtimer Added

Resources/Textures/DeltaV/Structures/Doors/Airlocks/Glass/justice.rsi

State Old New Status
assembly Added
bolted_unlit Added
closed Added
closed_unlit Added
closing Added
closing_unlit Added
deny_unlit Added
emergency_unlit Added
open Added
opening Added
opening_unlit Added
panel_closing Added
panel_open Added
panel_opening Added
sparks Added
sparks_broken Added
sparks_damaged Added
sparks_open Added
welded Added

Resources/Textures/DeltaV/Structures/Doors/Airlocks/Standard/justice.rsi

State Old New Status
assembly Added
bolted_unlit Added
closed Added
closed_unlit Added
closing Added
closing_unlit Added
deny_unlit Added
emergency_unlit Added
open Added
opening Added
opening_unlit Added
panel_closing Added
panel_open Added
panel_opening Added
sparks Added
sparks_broken Added
sparks_damaged Added
sparks_open Added
welded Added

Resources/Textures/DeltaV/Structures/Wallmounts/signs.rsi

State Old New Status
direction_court Added
direction_justice Added

Resources/Textures/Objects/Misc/bureaucracy.rsi

State Old New Status
paper_stamp-notary Added

Resources/Textures/Structures/Storage/closet.rsi

State Old New Status
cj Added
cj_door Added
cj_open Added
clerk Added
clerk_door Added
clerk_open Added

Edit: diff updated after 0a50c5d

@github-actions github-actions bot added Changes: Audio Changes any ogg files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI labels Aug 5, 2024
@Mnemotechnician
Copy link
Contributor

No, no no no.
Delta playerbase already hates it, we definitely don't need it here.

@DangerRevolution
Copy link
Contributor

No, no no no. Delta playerbase already hates it, we definitely don't need it here.

this is needed for all future updates

@leonardo-dabepis
Copy link
Contributor

No, no no no. Delta playerbase already hates it, we definitely don't need it here.

Delta playerbase hates everything good + they don't understand roleplay (essential for a roleplay-based department) + most of them refuse to read space law and SOP or even the game rules + the department was unfinished at time of release which caused sec mains to have a permanent hateboner for it + the things that made it bad were fixed a month ago + it loses so much potential from being only on Delta because it is NOT taken seriously over there at all + L + ratio

But I like to think that it'd work better for a roleplay-based codebase such as EE.

@ShatteredSwords
Copy link
Contributor

Security needs an opposing force to prevent what people call "ShitSec". Space law is supposed to do that, but it doesn't work in a multitude of servers. Having an entire department that revolves around keeping security in check WITH space law, while being good for roleplay, is honestly THE solution, unless those of you who oppose have a better one that doesn't include admin intervention. I think this is a great department to have, in the right hands.

@TadJohnson00
Copy link
Contributor

No, no no no. Delta playerbase already hates it, we definitely don't need it here.

The more the Delta playerbase hates something, the more it's worth porting as a general rule. To succinctly sum up what Leo said - at the risk of appearing facetious - Delta V, broadly generalised, is more concerned as a whole about mechanical advantages, meming and shitter behaviour, and exerting their own generally infantile will on the station and community as a whole.

Justice, originally intended to be a more serious department, would work for a more conscientious playerbase, stronger admin intervention, and generally better players, to fulfill its role of facilitating security efforts and general station upkeep. If you don't want it to turn out like Delta, put better players in Security and Justice - and, well, pretty much every department. Plus, as mentioned, it's an integral part of Delta V's maps and general SOP, even if you disagree with Security having any checks or balances; it's gotta happen unless you're reworking it more or less from the ground up.

@github-actions github-actions bot added the Status: Needs Review Someone please review this label Aug 5, 2024
@DangerRevolution
Copy link
Contributor

Once we get Delta-V maps ported; there'll be variants made without the Justice department (primarily as we don't have SoP or SL guidebooked). This is needed for future departments.

About above ^
Delta-V struggles with chronic shitterism. Until all the people saying "I refuse to do Paperwork RP" or "I am not going to read SoP, CP or SL" are permabanned from Delta, Justice will never work as intended. It'll be made to work on EE one day, that isn't today. This is just a stepping stone PR.

@DangerRevolution
Copy link
Contributor

Also, this is being set to draft until the TODO is done.

@DangerRevolution DangerRevolution marked this pull request as draft August 5, 2024 11:13
@VMSolidus VMSolidus marked this pull request as ready for review August 5, 2024 15:46
@VMSolidus
Copy link
Member Author

Also, this is being set to draft until the TODO is done.

Not my TODO, not going to fucking do that. Fuck no. This is a cherry-pick of a content PR required so that we can continue doing our work of cherry-picking Delta. This PR changes literally nothing about how our codebase plays. Our maps still have Lawyer, none of the new jobs even spawn in maps. I'm re-opening this PR.

@DangerRevolution
Copy link
Contributor

Also, this is being set to draft until the TODO is done.

Not my TODO, not going to fucking do that. Fuck no. This is a cherry-pick of a content PR required so that we can continue doing our work of cherry-picking Delta. This PR changes literally nothing about how our codebase plays. Our maps still have Lawyer, none of the new jobs even spawn in maps. I'm re-opening this PR.

didn't realise it was in quotes lol

@VMSolidus VMSolidus removed Status: Needs Cleanup Someone has to clean this before merging Status: Do Not Merge Do not merge labels Aug 5, 2024
@OldDanceJacket
Copy link
Contributor

No, no no no. Delta playerbase already hates it, we definitely don't need it here.

Delta playerbase hates everything good + they don't understand roleplay (essential for a roleplay-based department) + most of them refuse to read space law and SOP or even the game rules + the department was unfinished at time of release which caused sec mains to have a permanent hateboner for it + the things that made it bad were fixed a month ago + it loses so much potential from being only on Delta because it is NOT taken seriously over there at all + L + ratio

But I like to think that it'd work better for a roleplay-based codebase such as EE.

It's a horribly implemented department in every aspect that fails at the whiteboard suggestion stage.

It takes an aspect of the game(courtroom rp) that isn't meant to be an every round thing, that suffers from players meandering through the roleplay of it because and has to have a number of things line up perfectly to happen and usually is just ten minutes of people taking forever to type. Courtroom RP should've had attention given to it, some rules refined for Lawyers and those that wished to engage in it, but the solution was to make the process as quick and painless as possible.

Not to butcher SOP, space law, every map, and the flow of the round by trying to make it not only happen every round(still doesn't happen lmao) and to make it so it takes even LONGER to get through it.

It doesn't aid rp, it doesn't introduce more interesting scenarios, and it bogs down the majority of the game elsewhere. There are zero positives related to the Justice Department.

Anyways I'm merging.

@OldDanceJacket OldDanceJacket merged commit 32b08b0 into Simple-Station:master Aug 6, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OldDanceJacket OldDanceJacket OldDanceJacket approved these changes

@DangerRevolution DangerRevolution DangerRevolution approved these changes

@DEATHB4DEFEAT DEATHB4DEFEAT Awaiting requested review from DEATHB4DEFEAT

@Pspritechologist Pspritechologist Awaiting requested review from Pspritechologist

Assignees

@VMSolidus VMSolidus

Labels
Changes: Audio Changes any ogg files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 1-Very Large For especially large issues/PRs Status: Needs Review Someone please review this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@VMSolidus @Mnemotechnician @DangerRevolution @leonardo-dabepis @ShatteredSwords @TadJohnson00 @OldDanceJacket