-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oni Speech Update #724
Merged
DangerRevolution
merged 5 commits into
Simple-Station:master
from
angelofallars:oni-speech-bubbles
Aug 13, 2024
Merged
Oni Speech Update #724
DangerRevolution
merged 5 commits into
Simple-Station:master
from
angelofallars:oni-speech-bubbles
Aug 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: Localization
Changes any ftl files
Changes: Sprite
Changes any png or json in an RSI
Changes: YML
Changes any yml files
labels
Aug 12, 2024
I've been pinged!! 😭 |
DangerRevolution
suggested changes
Aug 12, 2024
DangerRevolution
requested review from
VMSolidus,
DEATHB4DEFEAT,
Peptide90,
Pspritechologist and
OldDanceJacket
August 12, 2024 09:44
DangerRevolution
added
Size: 3-Medium
For medium issues/PRs
Priority: 3-Medium
Needs to be resolved at some point
Type: Feature
Creation of or significant changes to a feature
labels
Aug 12, 2024
Co-authored-by: Danger Revolution! <[email protected]> Signed-off-by: Angelo Fallaria <[email protected]>
VMSolidus
approved these changes
Aug 13, 2024
DangerRevolution
approved these changes
Aug 13, 2024
SimpleStation14
added a commit
that referenced
this pull request
Aug 13, 2024
tmcqueen
pushed a commit
to tmcqueen/Syndicate-Station
that referenced
this pull request
Aug 24, 2024
# Description This PR has updates surrounding Oni speech: a new speech bubble for Onis with horns, unique speech verbs, and a tweak to the Nekomimetic description to mention Onis. Notably, Onis will now have a **fully unique** speech (sound, speech bubble, verbs), improving how distinct they feel. Simple-Station#711 (Remove Or Rework Vulpkanin) triggered a discussion about how unique the species should be in EE. As an Oni main, I can't help but notice that Onis often feel like human reskins, practically being colorful humans with horns. This PR aims to be a step in the right direction to make Onis more aesthetically distinct from humans by changing the visuals of their speech. All that is left is to give them unique screams, preferably screams that sound rather *demonic*. Shoutout to @leonardo-dabepis who improved the chat bubble horns for me. I will impulsively put him in the changelog to give credit ## Media **Speech Bubble** ![image](https://github.com/user-attachments/assets/71185797-40b9-437b-a360-7ffcac83705b) <details><summary>See more</summary> **Speech Style** ![image](https://github.com/user-attachments/assets/67ef53f9-d713-40c4-a88f-903d7be4f55a) **Nekomimetic Description** ![image](https://github.com/user-attachments/assets/c3df58db-22d1-44a1-8f0c-84e879ad0c7f) </details> ## Changelog :cl: Skubman and leonardo-dabepis - add: Onis now get a unique speech bubble, a black bubble with horns. - add: Onis have received a distinct speech style that reflects their strength. Hear them 'grunt', 'bellow', 'blare', and 'rumble' as they talk. - tweak: The Nekomimetic language description has been changed to mention Onis speaking it. --------- Signed-off-by: Angelo Fallaria <[email protected]> Co-authored-by: Danger Revolution! <[email protected]>
tmcqueen
pushed a commit
to tmcqueen/Syndicate-Station
that referenced
this pull request
Aug 24, 2024
tmcqueen
pushed a commit
to tmcqueen/Syndicate-Station
that referenced
this pull request
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes: Localization
Changes any ftl files
Changes: Sprite
Changes any png or json in an RSI
Changes: YML
Changes any yml files
Priority: 3-Medium
Needs to be resolved at some point
Size: 3-Medium
For medium issues/PRs
Status: Needs Review
Someone please review this
Type: Feature
Creation of or significant changes to a feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has updates surrounding Oni speech: a new speech bubble for Onis with horns, unique speech verbs, and a tweak to the Nekomimetic description to mention Onis.
Notably, Onis will now have a fully unique speech (sound, speech bubble, verbs), improving how distinct they feel.
#711 (Remove Or Rework Vulpkanin) triggered a discussion about how unique the species should be in EE.
As an Oni main, I can't help but notice that Onis often feel like human reskins, practically being colorful humans with horns. This PR aims to be a step in the right direction to make Onis more aesthetically distinct from humans by changing the visuals of their speech. All that is left is to give them unique screams, preferably screams that sound rather demonic.
Shoutout to @leonardo-dabepis who improved the chat bubble horns for me. I will impulsively put him in the changelog to give credit
Media
Speech Bubble
See more
Speech Style
Nekomimetic Description
Changelog
🆑 Skubman and leonardo-dabepis