Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psionic Power Feedback Messages #776

Conversation

VMSolidus
Copy link
Member

@VMSolidus VMSolidus commented Aug 21, 2024

Description

This PR implements the previously planned feature whereby obtaining a Psionic Power plays some form of notification to alert the player that they have gained a new ability. Since some Psionics like Xenoglossy are purely passive, it's very important to give an indication to players what's going on. To that end, PsionicPowerPrototype has been expanded to include new datafields related to Initialization Feedback. There are now three kinds of feedback messages: Popup, Feedback, and Metapsionic.

All feedback will only play for powers obtained during the round, rather than for entities that innately start with powers.

  • Popups will appear over your character's head as a small, brief message. These should be no more than a sentence at most.
  • Feedback will appear in the Chat window as a message only visible to the Psion themself. These can be as much as a paragraph in length.
  • Metapsionic messages are coming in their own separate PR: Psi-Potentiometry Power #774

In a separate PR, I also wish to add Audio feedback as well.

Media

I apologize that the video has been bitcrunched to a point that the chat window can't be read.

8mb.video-5yV-CM2BLnog.mp4

Changelog

🆑

  • add: Gaining a new Psionic Power can now display messages to alert the player, both as a short popup, and optionally a lengthier message sent to the user's Chat window.

@github-actions github-actions bot added the Changes: C# Changes any cs files label Aug 21, 2024
@github-actions github-actions bot added the Changes: YML Changes any yml files label Aug 21, 2024
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Aug 22, 2024
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the use case for displaying a message in chat but not over your head, excluding situations where you use both

/// What color will the initialization feedback display in the chat window with.
/// </summary>
[DataField]
public string InitializationFeedbackColor = "#8A00C2";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this something that contrasts better with chat

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I'll take it one more step up the chain. That should be good. :)

@VMSolidus VMSolidus merged commit 214e896 into Simple-Station:master Aug 22, 2024
11 checks passed
@VMSolidus
Copy link
Member Author

Oh damnit I hit the wrong button.

SimpleStation14 added a commit that referenced this pull request Aug 22, 2024
@ShatteredSwords
Copy link
Contributor

Oh damnit I hit the wrong button.

Who could have forseen these unfortunate circumstances?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants