We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug When running extractIBAN, the extracted account number for German IBANs is only 9 digits when it should be 10.
Example IBANs:
Official docs from the Deutsche Bundesbank:
To Reproduce Run this test:
import { extractIBAN } from 'ibantools'; describe('ibantools', () => { it('just works, () => { expect(extractIBAN('DE22 1001 0050 0123 4567 89').accountNumber).toBe( '0123456789' ); }); });
Expected behavior The test should pass.
Environment: ibantools v4.5.1
The text was updated successfully, but these errors were encountered:
Fix for extraction of German account number
17b1250
Fixes #550
Simplify
Successfully merging a pull request may close this issue.
Describe the bug
When running extractIBAN, the extracted account number for German IBANs is only 9 digits when it should be 10.
Example IBANs:
Official docs from the Deutsche Bundesbank:
![image](https://private-user-images.githubusercontent.com/7560166/334151874-a0ad2b5e-ee52-4674-be67-5ef868b1e60c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM4OTMyNjQsIm5iZiI6MTcyMzg5Mjk2NCwicGF0aCI6Ii83NTYwMTY2LzMzNDE1MTg3NC1hMGFkMmI1ZS1lZTUyLTQ2NzQtYmU2Ny01ZWY4NjhiMWU2MGMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgxNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MTdUMTEwOTI0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OTM3M2U0YzFlNjcyMTAzZDY2ZWIyYmYxZDRlZWMyNzE1ZTQyNTUxZmMxZTU4YTc2ODBlZWQ1YjQ4NmFjN2M2YSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.JtJCFE7OO1q6Toz15G5ymfr1w7v0sxKPcP0TmigbBac)
To Reproduce
Run this test:
Expected behavior
The test should pass.
Environment:
ibantools v4.5.1
The text was updated successfully, but these errors were encountered: