From 0b2b43c7eca34c706f9aad8c2379c588c965cb00 Mon Sep 17 00:00:00 2001
From: Su5eD <su5ed@outlook.com>
Date: Wed, 14 Aug 2024 10:19:44 +0200
Subject: [PATCH] Re-add LVT scope transformer

Fixes #1295
---
 .../sinytra/connector/ConnectorCoremods.java  | 22 ++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/sinytra/connector/ConnectorCoremods.java b/src/main/java/org/sinytra/connector/ConnectorCoremods.java
index d93b634c..8921605d 100644
--- a/src/main/java/org/sinytra/connector/ConnectorCoremods.java
+++ b/src/main/java/org/sinytra/connector/ConnectorCoremods.java
@@ -10,14 +10,17 @@
 import net.neoforged.neoforgespi.coremod.ICoreMod;
 import org.objectweb.asm.MethodVisitor;
 import org.objectweb.asm.Opcodes;
+import org.objectweb.asm.Type;
 import org.objectweb.asm.tree.ClassNode;
 import org.objectweb.asm.tree.FieldNode;
 import org.objectweb.asm.tree.InsnList;
 import org.objectweb.asm.tree.InsnNode;
+import org.objectweb.asm.tree.LocalVariableNode;
 import org.objectweb.asm.tree.MethodInsnNode;
 import org.objectweb.asm.tree.MethodNode;
 import org.objectweb.asm.tree.TypeInsnNode;
 import org.objectweb.asm.tree.VarInsnNode;
+import org.sinytra.adapter.patch.analysis.locals.LocalVariableLookup;
 import org.slf4j.Logger;
 
 import java.util.List;
@@ -113,12 +116,29 @@ public Iterable<? extends ITransformer<?>> getTransformers() {
                 }
             }
         );
+        ITransformer<?> expandLocalVarScope = new BaseTransformer<>(
+            TargetType.METHOD,
+            ITransformer.Target.targetMethod("net.minecraft.world.entity.LivingEntity", "forceAddEffect", "(Lnet/minecraft/world/effect/MobEffectInstance;Lnet/minecraft/world/entity/Entity;)V"),
+            input -> {
+                LocalVariableLookup lvt = new LocalVariableLookup(input);
+                LocalVariableNode mobEffect = lvt.getByTypedOrdinal(Type.getObjectType("net/minecraft/world/effect/MobEffectInstance"), 1).orElse(null);
+                if (mobEffect != null) {
+                    mobEffect.start = lvt.getByIndex(0).start;
+                    input.instructions.insert(mobEffect.start, ASMAPI.listOf(
+                        new InsnNode(Opcodes.ACONST_NULL),
+                        new VarInsnNode(Opcodes.ASTORE, mobEffect.index)
+                    ));
+                    LOGGER.debug("Expanded local variable scope for LivingEntity#forceAddEffect index {}", mobEffect.index);
+                }
+            }
+        );
 
         return ImmutableList.<ITransformer<?>>builder()
             .add(keyMappingFieldTypeTransform, creativeModeTabConstructorTransform)
             .addAll(addedFields)
             .addAll(getFabricASMTransformers())
             .add(missingOrderingCall)
+            .add(expandLocalVarScope)
             .build();
     }
 
@@ -128,7 +148,7 @@ private static ITransformer<?> addFieldToClass(String cls, String name, String d
             ITransformer.Target.targetClass(cls),
             input -> {
                 input.fields.add(new FieldNode(access, name, desc, null, null));
-                
+
                 LOGGER.debug("Added field {} to class {}", name, cls);
             }
         );