Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nvidium incompatability #518

Closed
Matthew-MBG opened this issue Nov 19, 2023 · 12 comments · Fixed by #520
Closed

Nvidium incompatability #518

Matthew-MBG opened this issue Nov 19, 2023 · 12 comments · Fixed by #520
Assignees
Labels
compat A mod is found to be incompatible

Comments

@Matthew-MBG
Copy link

Mod Name

Nvidium

Mod Homepage

https://github.com/MCRcortex/nvidium

Describe the bug

The game does not open due to relying on Sodium.

Steps to reproduce

  1. Open the game
  2. Don't profit

Logs

https://pastebin.com/raw/HfUjXuNs

Additional context

No response

@Matthew-MBG Matthew-MBG added the compat A mod is found to be incompatible label Nov 19, 2023
@Matthew-MBG
Copy link
Author

Matthew-MBG commented Nov 19, 2023

I also tried forking Nvidium, and changed the mod requirements to Embeddium with it's latest version. The game opened, and then even showed Nvidium in the video settings, however upon joining a world, the game crashes, likely due to a rendering error.

Crash log:
https://pastebin.com/raw/wP6naezM

@VOLKOUL
Copy link

VOLKOUL commented Nov 20, 2023

Maaan, having Nvidium on Forge too would be so cool tho!

@MCRcortex
Copy link

@Matthew-MBG you need to upload the full log, this is just the tail end of the crash, however iirc it was something to do with the shader loader not looking in the nvidium jar for the shader

@Su5eD Su5eD moved this from 🆕 New to 🔖 Confirmed in Connector Triage Nov 24, 2023
@Su5eD Su5eD moved this from 🔖 Confirmed to 🏗 In progress in Connector Triage Nov 24, 2023
@Su5eD
Copy link
Member

Su5eD commented Nov 24, 2023

The issue came down to Nvidium not being able to load a shader, which later resulted in the game crashing. I've submitted a fix for this to embeddium which allows it to load shaders from other mods as well, restoring the original sodium behavior.

@Su5eD Su5eD moved this from 🏗 In progress to 👀 In review in Connector Triage Nov 24, 2023
@MCRcortex
Copy link

thank you! Much appreciated for the effort and (hopefully) fix

@Su5eD Su5eD self-assigned this Nov 25, 2023
@Su5eD Su5eD linked a pull request Nov 25, 2023 that will close this issue
@Matthew-MBG
Copy link
Author

image
Thanks for the fix! This now works!

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Connector Triage Nov 25, 2023
@VOLKOUL
Copy link

VOLKOUL commented Nov 27, 2023

YOOO! I think changes are coming!
Nvidirubidium is in it's alpha stage for now, right? Can't wait for it to get a release!
Have you tested it with shaders or does it not support them? (I think Nvidium itself doesn't)

@Matthew-MBG
Copy link
Author

Matthew-MBG commented Nov 27, 2023

@Wanderer70, they do in fact work (I edited a file to make it look for Oculus rather than Iris), but "working" means Revidium (new name) disables itself. Do remember, this is simply just me modifying like 4 files to get the requirements working, and I am no developer.

@VOLKOUL
Copy link

VOLKOUL commented Nov 27, 2023

Awesome! If it works, it works.

@hiimrickross
Copy link

@Wanderer70, they do in fact work (I edited a file to make it look for Oculus rather than Iris), but "working" means Revidium (new name) disables itself. Do remember, this is simply just me modifying like 4 files to get the requirements working, and I am no developer.

wait so.... if you use nvidium with sinytra via your adjustments, it works - but if you use shaders like complimentaryreimagined, nvidium will disable itself ? just wondering since i added your first file "Thanks for the fix! This now works!" post, and i got into my world just fine. Going to try the latest commit #12 where its labelled revidium now... And then without it for performance comparison.

@Matthew-MBG-Alt
Copy link

Just an update for Revidium:

The project has served its purpose, and a more talented developer has continued the same idea under the name acedium. Revidium is now abandoned.

@VOLKOUL
Copy link

VOLKOUL commented Apr 6, 2024

NVIDIUM can actually work with Connector now. Make sure you are using Embeddium as a replacement to Sodium. All you have to do is make two config files in the Minecraft config folder:

connector.json :

{
"version": 1,
"hiddenMods": [],
"globalModAliases": {
"cloth_config": "cloth-config2",
"playeranimator": "player-animator",
"embeddium": ["sodium"]
}
}

fabric_loader_dependencies.json :

{
"version": 1,
"overrides":{
"nvidium":{
"-depends":{
"sodium": "IGNORED"
},
"+depends":{
"sodium": "*"
}
}
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat A mod is found to be incompatible
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

6 participants