Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update graphql-request #2012

Open
Dmitrijs-Sakovics opened this issue Jan 17, 2025 · 0 comments
Open

Please update graphql-request #2012

Dmitrijs-Sakovics opened this issue Jan 17, 2025 · 0 comments
Labels

Comments

@Dmitrijs-Sakovics
Copy link

Describe the Bug

The package @sitecore-jss/sitecore-jss has a dependency on "graphql-request": "^4.2.0". This has a downstream dependency on punycode, which under Node.Js 22 raises a deprecation message.

Later versions of graphql-request (latest is 7.1.2) do not have this downstream dependency

To Reproduce

  1. use Node.Js 22
  2. run anything that uses @sitecore-jss/sitecore-jss
  3. observe the deprecation message:
    Image

Expected Behavior

No deprecation message shown

Possible Fix

the deprecation message can be traced to a very old version of [email protected] used downstream:
Image
Later versions of graphql-request have removed the cross-fetch dependency and do not exhibit the same problem

Provide environment information

  • Sitecore Version: 10.3
  • JSS Version: 21
  • Environment Name and version: Node 22.13.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant