From 61935ea482e772252d9e795efcdf92a50892b54c Mon Sep 17 00:00:00 2001 From: Antonytm Date: Fri, 22 Dec 2023 11:14:58 +0200 Subject: [PATCH 1/3] Move GraphQL to peer dependencies --- packages/sitecore-jss/package.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/sitecore-jss/package.json b/packages/sitecore-jss/package.json index c41c51133d..c821e1bd9f 100644 --- a/packages/sitecore-jss/package.json +++ b/packages/sitecore-jss/package.json @@ -55,12 +55,14 @@ "axios": "^0.21.1", "chalk": "^4.1.0", "debug": "^4.3.1", - "graphql": "^16.5.0", - "graphql-request": "^4.2.0", "lodash.unescape": "^4.0.1", "memory-cache": "^0.2.0", "url-parse": "^1.5.9" }, + "peerDependencies": { + "graphql": "^16.5.0", + "graphql-request": "^4.2.0" + }, "description": "", "types": "types/index.d.ts", "gitHead": "2f4820efddf4454eeee58ed1b2cc251969efdf5b", From 1d6c7dda8db5f3036c2dda9f33c7daedd9163410 Mon Sep 17 00:00:00 2001 From: Antonytm Date: Wed, 27 Dec 2023 16:46:26 +0200 Subject: [PATCH 2/3] PoC: working build --- packages/sitecore-jss/package.json | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/sitecore-jss/package.json b/packages/sitecore-jss/package.json index c821e1bd9f..41b86d0bce 100644 --- a/packages/sitecore-jss/package.json +++ b/packages/sitecore-jss/package.json @@ -39,11 +39,14 @@ "@types/mocha": "^9.0.0", "@types/node": "^16.11.6", "@types/url-parse": "1.4.8", + "axios": "^0.21.1", "chai": "^4.2.0", "chai-spies": "^1.0.0", "chai-string": "^1.5.0", "del-cli": "^5.0.0", "eslint": "^7.15.0", + "graphql": "^16.5.0", + "graphql-request": "^4.2.0", "mocha": "^10.2.0", "nock": "^13.0.5", "nyc": "^15.1.0", @@ -52,7 +55,6 @@ "typescript": "~4.3.5" }, "dependencies": { - "axios": "^0.21.1", "chalk": "^4.1.0", "debug": "^4.3.1", "lodash.unescape": "^4.0.1", @@ -60,6 +62,7 @@ "url-parse": "^1.5.9" }, "peerDependencies": { + "axios": "^0.21.1", "graphql": "^16.5.0", "graphql-request": "^4.2.0" }, From 46ecfe77ec5b1a8c0648558e43ab930620310e42 Mon Sep 17 00:00:00 2001 From: Antonytm Date: Wed, 27 Dec 2023 16:51:57 +0200 Subject: [PATCH 3/3] Update packages to fix build --- package.json | 1 + yarn.lock | 7 ++++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 1f275c34d0..4ca4777705 100644 --- a/package.json +++ b/package.json @@ -22,6 +22,7 @@ "url": "https://github.com/sitecore/jss/issues" }, "devDependencies": { + "@types/debug": "^4.1.12", "@typescript-eslint/eslint-plugin": "^4.10.0", "@typescript-eslint/parser": "^4.10.0", "eslint": "^7.16.0", diff --git a/yarn.lock b/yarn.lock index 3df9a4c97f..f5a193dc96 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5777,6 +5777,10 @@ __metadata: tslib: ^1.10.0 typescript: ~4.3.5 url-parse: ^1.5.9 + peerDependencies: + axios: ^0.21.1 + graphql: ^16.5.0 + graphql-request: ^4.2.0 languageName: unknown linkType: soft @@ -6051,7 +6055,7 @@ __metadata: languageName: node linkType: hard -"@types/debug@npm:^4.1.5": +"@types/debug@npm:^4.1.12, @types/debug@npm:^4.1.5": version: 4.1.12 resolution: "@types/debug@npm:4.1.12" dependencies: @@ -23062,6 +23066,7 @@ __metadata: version: 0.0.0-use.local resolution: "root-workspace-0b6124@workspace:." dependencies: + "@types/debug": ^4.1.12 "@typescript-eslint/eslint-plugin": ^4.10.0 "@typescript-eslint/parser": ^4.10.0 eslint: ^7.16.0