Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non string types are not persisted in the generated designers #26

Open
mrfalafel opened this issue Jul 11, 2019 · 2 comments
Open

Non string types are not persisted in the generated designers #26

mrfalafel opened this issue Jul 11, 2019 · 2 comments

Comments

@mrfalafel
Copy link

Creating a widget using CLI produces a designer javascript file that is not converting non string properties to string to be able to display them in the simple designer.

To reproduce:
Add 2 more public properties to the controller
public int Number {get; set;}
public bool YesNo {get; set;}

in the view display the 2 properties using input types number and checkbox using the correct syntax for Angular binding to the perspective properties.

You will notice that you can make changes to the designer but they don't show up upon return to the designer. The Advanced designer is working correctly.

Developers should not modify the js file themselves to do something as simple as converting these types to strings, it should be part of the CLI template generation automatically.

@orlindraganov
Copy link
Contributor

Hello Lino,
We'll take a look at it.
Thanks for reporting!

@TheTrainingBoss
Copy link

I submitted PR #33 to fix this issue.
Thanks
-Lino

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants