From f49666e9ba063d57bbd197aa78602824fbe46159 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rolf=20Christian=20J=C3=B8rgensen?=
 <114920418+rcj-siteimprove@users.noreply.github.com>
Date: Tue, 19 Dec 2023 14:19:12 +0100
Subject: [PATCH] Assume audio is playing and that it has controls based on
 attributes (#1538)

* Update audio applicability

* Add tests for autoplay case

* Update audio applicability

It now ask about play button when controls attribute is present on
element

* Add changeset

* Add tests for audio elements with autoplay and controls attributes

These tests exemplify that the `is-playing` and `play-button` questions are not needed anymore for the rules to pass or fail when the relevant attributes are present.

* Fix test
---
 .changeset/tasty-stingrays-grab.md            |   5 +
 .../src/common/applicability/audio.ts         |  28 ++--
 .../alfa-rules/test/sia-r23/rule.spec.tsx     | 135 ++++++++++++++++
 .../alfa-rules/test/sia-r29/rule.spec.tsx     | 153 ++++++++++++++++++
 4 files changed, 309 insertions(+), 12 deletions(-)
 create mode 100644 .changeset/tasty-stingrays-grab.md

diff --git a/.changeset/tasty-stingrays-grab.md b/.changeset/tasty-stingrays-grab.md
new file mode 100644
index 0000000000..b724e25746
--- /dev/null
+++ b/.changeset/tasty-stingrays-grab.md
@@ -0,0 +1,5 @@
+---
+"@siteimprove/alfa-rules": patch
+---
+
+**Changed:** Media rules R23 and R29 no longer asks if audio is playing or where the play buttons is when the attributes `autoplay` and `controls` are present respectively.
diff --git a/packages/alfa-rules/src/common/applicability/audio.ts b/packages/alfa-rules/src/common/applicability/audio.ts
index 335cb4b90b..344a7d0e9a 100644
--- a/packages/alfa-rules/src/common/applicability/audio.ts
+++ b/packages/alfa-rules/src/common/applicability/audio.ts
@@ -17,7 +17,7 @@ import { Style } from "@siteimprove/alfa-style";
 import { Question } from "../act/question";
 
 const { isPerceivableForAll } = DOM;
-const { isElement, hasName, hasNamespace } = Element;
+const { isElement, hasName, hasNamespace, hasAttribute } = Element;
 const { and } = Predicate;
 const { isRendered } = Style;
 const { getElementDescendants } = Query;
@@ -44,17 +44,21 @@ export function audio(
         Question.of("is-audio-streaming", element).map((isStreaming) =>
           isStreaming
             ? None
-            : Question.of("is-playing", element).map((isPlaying) =>
-                isPlaying
-                  ? Option.of(element)
-                  : Question.of("play-button", element).map((playButton) =>
-                      playButton.some(
-                        and(isElement, isPerceivableForAll(device)),
-                      )
-                        ? Option.of(element)
-                        : None,
-                    ),
-              ),
+            : Question.of("is-playing", element)
+                .answerIf(hasAttribute("autoplay"), true)
+                .map((isPlaying) =>
+                  isPlaying
+                    ? Option.of(element)
+                    : Question.of("play-button", element)
+                        .answerIf(hasAttribute("controls"), Option.of(element))
+                        .map((playButton) =>
+                          playButton.some(
+                            and(isElement, isPerceivableForAll(device)),
+                          )
+                            ? Option.of(element)
+                            : None,
+                        ),
+                ),
         ),
       ),
   );
diff --git a/packages/alfa-rules/test/sia-r23/rule.spec.tsx b/packages/alfa-rules/test/sia-r23/rule.spec.tsx
index c60a0c6d19..7cc75c172f 100755
--- a/packages/alfa-rules/test/sia-r23/rule.spec.tsx
+++ b/packages/alfa-rules/test/sia-r23/rule.spec.tsx
@@ -37,6 +37,59 @@ test(`evaluate() passes an audio with perceivable transcript`, async (t) => {
   );
 });
 
+test(`evaluate() passes an audio with autoplay attribute and with perceivable transcript`, async (t) => {
+  const target = <audio src="foo.mp3" autoplay />;
+  const transcript = <div>Hello</div>;
+
+  const document = h.document([target, transcript]);
+
+  t.deepEqual(
+    await evaluate(
+      R23,
+      { document },
+      oracle({
+        "is-audio-streaming": false,
+        transcript: Option.of(transcript),
+      }),
+    ),
+    [
+      passed(
+        R23,
+        target,
+        { 1: Outcomes.HasPerceivableTranscript("<audio>") },
+        Outcome.Mode.SemiAuto,
+      ),
+    ],
+  );
+});
+
+test(`evaluate() passes a non-playing audio with controls attribute and with perceivable transcript`, async (t) => {
+  const target = <audio src="foo.mp3" controls />;
+  const transcript = <div>Hello</div>;
+
+  const document = h.document([target, transcript]);
+
+  t.deepEqual(
+    await evaluate(
+      R23,
+      { document },
+      oracle({
+        "is-audio-streaming": false,
+        "is-playing": false,
+        transcript: Option.of(transcript),
+      }),
+    ),
+    [
+      passed(
+        R23,
+        target,
+        { 1: Outcomes.HasPerceivableTranscript("<audio>") },
+        Outcome.Mode.SemiAuto,
+      ),
+    ],
+  );
+});
+
 test(`evaluate() passes an audio with a link to a transcript`, async (t) => {
   const target = <audio src="foo.mp3" />;
   const transcript = <a href="transcript.html">Read transcript</a>;
@@ -92,6 +145,59 @@ test(`evaluate() fails an audio with no transcript`, async (t) => {
   );
 });
 
+test(`evaluate() fails an audio with autoplay attribute and no transcript`, async (t) => {
+  const target = <audio src="foo.mp3" autoplay />;
+
+  const document = h.document([target]);
+
+  t.deepEqual(
+    await evaluate(
+      R23,
+      { document },
+      oracle({
+        "is-audio-streaming": false,
+        transcript: None,
+        "transcript-link": None,
+      }),
+    ),
+    [
+      failed(
+        R23,
+        target,
+        { 1: Outcomes.HasNoTranscriptLink("<audio>") },
+        Outcome.Mode.SemiAuto,
+      ),
+    ],
+  );
+});
+
+test(`evaluate() fails a non-playing audio with controls attribute and no transcript`, async (t) => {
+  const target = <audio src="foo.mp3" controls />;
+
+  const document = h.document([target]);
+
+  t.deepEqual(
+    await evaluate(
+      R23,
+      { document },
+      oracle({
+        "is-audio-streaming": false,
+        "is-playing": false,
+        transcript: None,
+        "transcript-link": None,
+      }),
+    ),
+    [
+      failed(
+        R23,
+        target,
+        { 1: Outcomes.HasNoTranscriptLink("<audio>") },
+        Outcome.Mode.SemiAuto,
+      ),
+    ],
+  );
+});
+
 test(`evaluates() fails an audio with non-perceivable transcript`, async (t) => {
   const target = <audio src="foo.mp3" />;
   const transcript = <div style={{ visibility: "hidden" }}>Hello</div>;
@@ -200,6 +306,35 @@ test(`evaluate() cannot tell if questions are left unanswered`, async (t) => {
   );
 });
 
+test(`evaluate() cannot tell for audio with autoplay attribute and not answered expectation questions`, async (t) => {
+  const target = <audio src="foo.mp3" autoplay />;
+
+  const document = h.document([target]);
+
+  t.deepEqual(
+    await evaluate(R23, { document }, oracle({ "is-audio-streaming": false })),
+    [cantTell(R23, target, undefined, Outcome.Mode.SemiAuto)],
+  );
+});
+
+test(`evaluate() cannot tell for non-playing audio with controls attribute and not answered expectation questions`, async (t) => {
+  const target = <audio src="foo.mp3" controls />;
+
+  const document = h.document([target]);
+
+  t.deepEqual(
+    await evaluate(
+      R23,
+      { document },
+      oracle({
+        "is-audio-streaming": false,
+        "is-playing": false,
+      }),
+    ),
+    [cantTell(R23, target, undefined, Outcome.Mode.SemiAuto)],
+  );
+});
+
 test(`evaluate() is inapplicable when Applicability questions are unanswered`, async (t) => {
   const target = <audio src="foo.mp3" />;
 
diff --git a/packages/alfa-rules/test/sia-r29/rule.spec.tsx b/packages/alfa-rules/test/sia-r29/rule.spec.tsx
index 09cb807dca..cea5f36d6c 100755
--- a/packages/alfa-rules/test/sia-r29/rule.spec.tsx
+++ b/packages/alfa-rules/test/sia-r29/rule.spec.tsx
@@ -42,6 +42,69 @@ test(`evaluate() passes an audio that is labelled as alternative for text`, asyn
   );
 });
 
+test(`evaluate() passes an audio with autoplay attribute that is labelled as alternative for text`, async (t) => {
+  const target = <audio src="foo.mp3" autoplay />;
+  const text = <p>Some very long text</p>;
+  const label = <span>Listen to this content as audio</span>;
+
+  const document = h.document([text, label, target]);
+
+  t.deepEqual(
+    await evaluate(
+      R29,
+      { document },
+      oracle({
+        "is-audio-streaming": false,
+        "text-alternative": Option.of(text),
+        label: Option.of(label),
+      }),
+    ),
+    [
+      passed(
+        R29,
+        target,
+        {
+          1: Outcomes.HasPerceivableAlternative("<audio>"),
+          2: Outcomes.HasPerceivableLabel("<audio>"),
+        },
+        Outcome.Mode.SemiAuto,
+      ),
+    ],
+  );
+});
+
+test(`evaluate() passes an non-playing audio with controls attribute that is labelled as alternative for text`, async (t) => {
+  const target = <audio src="foo.mp3" controls />;
+  const text = <p>Some very long text</p>;
+  const label = <span>Listen to this content as audio</span>;
+
+  const document = h.document([text, label, target]);
+
+  t.deepEqual(
+    await evaluate(
+      R29,
+      { document },
+      oracle({
+        "is-audio-streaming": false,
+        "is-playing": false,
+        "text-alternative": Option.of(text),
+        label: Option.of(label),
+      }),
+    ),
+    [
+      passed(
+        R29,
+        target,
+        {
+          1: Outcomes.HasPerceivableAlternative("<audio>"),
+          2: Outcomes.HasPerceivableLabel("<audio>"),
+        },
+        Outcome.Mode.SemiAuto,
+      ),
+    ],
+  );
+});
+
 test(`evaluate() fails an audio that is not alternative for text`, async (t) => {
   const target = <audio src="foo.mp3" />;
   const label = <span>Listen to this content as audio</span>;
@@ -73,6 +136,67 @@ test(`evaluate() fails an audio that is not alternative for text`, async (t) =>
   );
 });
 
+test(`evaluate() fails an audio with autoplay attribute that is not alternative for text`, async (t) => {
+  const target = <audio src="foo.mp3" autoplay />;
+  const label = <span>Listen to this content as audio</span>;
+
+  const document = h.document([label, target]);
+
+  t.deepEqual(
+    await evaluate(
+      R29,
+      { document },
+      oracle({
+        "is-audio-streaming": false,
+        "text-alternative": None,
+        label: Option.of(label),
+      }),
+    ),
+    [
+      failed(
+        R29,
+        target,
+        {
+          1: Outcomes.HasNoAlternative("<audio>"),
+          2: Outcomes.HasPerceivableLabel("<audio>"),
+        },
+        Outcome.Mode.SemiAuto,
+      ),
+    ],
+  );
+});
+
+test(`evaluate() fails a non-playing audio with controls attribute that is not alternative for text`, async (t) => {
+  const target = <audio src="foo.mp3" controls />;
+  const label = <span>Listen to this content as audio</span>;
+
+  const document = h.document([label, target]);
+
+  t.deepEqual(
+    await evaluate(
+      R29,
+      { document },
+      oracle({
+        "is-audio-streaming": false,
+        "is-playing": false,
+        "text-alternative": None,
+        label: Option.of(label),
+      }),
+    ),
+    [
+      failed(
+        R29,
+        target,
+        {
+          1: Outcomes.HasNoAlternative("<audio>"),
+          2: Outcomes.HasPerceivableLabel("<audio>"),
+        },
+        Outcome.Mode.SemiAuto,
+      ),
+    ],
+  );
+});
+
 test(`evaluate() fails an audio that is not labelled as alternative for text`, async (t) => {
   const target = <audio src="foo.mp3" />;
   const text = <p>Some very long text</p>;
@@ -187,6 +311,35 @@ test(`evaluate() cannot tell if questions are left unanswered`, async (t) => {
   );
 });
 
+test(`evaluate() cannot tell for audio with autoplay attribute and not answered expectation questions`, async (t) => {
+  const target = <audio src="foo.mp3" autoplay />;
+
+  const document = h.document([target]);
+
+  t.deepEqual(
+    await evaluate(R29, { document }, oracle({ "is-audio-streaming": false })),
+    [cantTell(R29, target, undefined, Outcome.Mode.SemiAuto)],
+  );
+});
+
+test(`evaluate() cannot tell for non-playing audio with controls attribute and not answered expectation questions`, async (t) => {
+  const target = <audio src="foo.mp3" controls />;
+
+  const document = h.document([target]);
+
+  t.deepEqual(
+    await evaluate(
+      R29,
+      { document },
+      oracle({
+        "is-audio-streaming": false,
+        "is-playing": false,
+      }),
+    ),
+    [cantTell(R29, target, undefined, Outcome.Mode.SemiAuto)],
+  );
+});
+
 test(`evaluate() is inapplicable when Applicability questions are unanswered`, async (t) => {
   const target = <audio src="foo.mp3" />;