Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute selector specificity at parse time. #1514

Merged
merged 16 commits into from
Nov 29, 2023
Merged

Compute selector specificity at parse time. #1514

merged 16 commits into from
Nov 29, 2023

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Nov 28, 2023

Part of #1486

Move the computation of selectors' specificity at the time the Selector object is built (usually at parse time). This allows for specific selectors to "cheat" with specificity calculation without making the shared code unreadable.

There is an unrelated change to alfa-test to make it easier to write ramdom tests, and this is refactored from alfa-map which was the only package doing random tests so far.

@Jym77 Jym77 self-assigned this Nov 28, 2023
@Jym77 Jym77 added the minor Backwards-compatible change that touches public API label Nov 28, 2023
@Jym77
Copy link
Contributor Author

Jym77 commented Nov 28, 2023

!pr extract

@Jym77 Jym77 marked this pull request as ready for review November 28, 2023 15:17
@Jym77 Jym77 requested a review from a team as a code owner November 28, 2023 15:17
Copy link
Contributor

@rcj-siteimprove rcj-siteimprove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Jym77 Jym77 added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit dfa47dc Nov 29, 2023
6 checks passed
@Jym77 Jym77 deleted the selector-specificity branch November 29, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Backwards-compatible change that touches public API
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants