Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline and test @siteimprove/alfa-cascade #1534

Merged
merged 26 commits into from
Dec 14, 2023
Merged

Streamline and test @siteimprove/alfa-cascade #1534

merged 26 commits into from
Dec 14, 2023

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Dec 13, 2023 •
edited
Loading

  • Add some documentation and tests to @siteimprove/alfa-cascade
  • Streamline a bit the ancestor filters and rule tree structures.

Jym77 added 21 commits December 6, 2023 09:22
@Jym77 Jym77 self-assigned this Dec 13, 2023
@Jym77 Jym77 added the major Backwards-incompatible change that touches public API label Dec 13, 2023
@Jym77 Jym77 changed the title Cascade test and cleanup Streamline and test @siteimprove/alfa-cascade Dec 13, 2023
@Jym77
Copy link
Contributor Author

Jym77 commented Dec 13, 2023

!pr extract

@Jym77 Jym77 marked this pull request as ready for review December 13, 2023 14:19
@Jym77 Jym77 requested a review from a team as a code owner December 13, 2023 14:19
@Jym77
Copy link
Contributor Author

Jym77 commented Dec 13, 2023

!pr extract

rcj-siteimprove
rcj-siteimprove approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@rcj-siteimprove rcj-siteimprove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏

@Jym77 Jym77 enabled auto-merge December 14, 2023 14:12
@Jym77 Jym77 added this pull request to the merge queue Dec 14, 2023
Merged via the queue into main with commit 66e2fd4 Dec 14, 2023
6 checks passed
@Jym77 Jym77 deleted the cascade-test-and-cleanup branch December 14, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcj-siteimprove rcj-siteimprove rcj-siteimprove approved these changes

Assignees

@Jym77 Jym77

Labels
major Backwards-incompatible change that touches public API
Projects
⚙️ Alfa Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jym77 @rcj-siteimprove