Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alfa-cascade: Clean up, refactor, add tests. #1540

Merged
merged 27 commits into from
Dec 20, 2023
Merged

alfa-cascade: Clean up, refactor, add tests. #1540

merged 27 commits into from
Dec 20, 2023

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Dec 20, 2023

No description provided.

Jym77 added 20 commits December 15, 2023 11:26
@Jym77
Move canReject as an AncestorFilter method
18dcc17
@Jym77
Start building Precedence interface
31f390c
@Jym77
Start building Precedence interface
a96312b
@Jym77
Add compareLexicographically
e8af202
@Jym77
Streamline cascade sorting order comparisons
096fdfb
@Jym77
Wrap Order into its own type (alias for number)
db1c600
@Jym77
Share block structure between rule tree and selector map
7beef8e
@Jym77
Add block builder with coupling
89090a1
@Jym77
Use bloĉk builder in selector map
e820644
@Jym77
Tighten typing
cd9e1d6
@Jym77
Add some tests
37181d9
@Jym77
Store rule type in abstract class
a2c1725
@Jym77
Revert "Store rule type in abstract class"
9d93ba4 
This reverts commit a2c1725.
@Jym77
Add selector map tests
1f0f3c9
@Jym77
Add some documentation and improve custom getting
fc471cb
@Jym77
Rename Cascade.of into Cascade.from
04a36b2
@Jym77
Revert "Rename Cascade.of into Cascade.from"
bac94f8 
This reverts commit 04a36b2.
@Jym77
Rename Cascade.of to Cascade.from
466fd24
@Jym77
Add tests
96118f5
@Jym77
Clean up
386ddda
@Jym77 Jym77 self-assigned this Dec 20, 2023
@Jym77 Jym77 added the major Backwards-incompatible change that touches public API label Dec 20, 2023
@Jym77
Copy link
Contributor Author

Jym77 commented Dec 20, 2023

!pr extract

@Jym77
Copy link
Contributor Author

Jym77 commented Dec 20, 2023

!pr extract

@Jym77 Jym77 marked this pull request as ready for review December 20, 2023 13:02
@Jym77 Jym77 requested a review from a team as a code owner December 20, 2023 13:02
rcj-siteimprove
rcj-siteimprove approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@rcj-siteimprove rcj-siteimprove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Jym77 Jym77 added this pull request to the merge queue Dec 20, 2023
Merged via the queue into main with commit 6e30457 Dec 20, 2023
6 checks passed
@Jym77 Jym77 deleted the cascade-test-cleanup-2 branch December 20, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcj-siteimprove rcj-siteimprove rcj-siteimprove approved these changes

Assignees

@Jym77 Jym77

Labels
major Backwards-incompatible change that touches public API
Projects
⚙️ Alfa Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jym77 @rcj-siteimprove