-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add style
attribute and importance to cascade sort
#1550
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!pr extract |
Jym77
added
minor
Backwards-compatible change that touches public API
and removed
major
Backwards-incompatible change that touches public API
labels
Jan 15, 2024
rcj-siteimprove
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1532
With CSS cascade level 5 (compared to level 4):
With this PR, both importance and style attribute are now part of the Cascade. This streamline
Style
building since all declarations are provided, and in decreasing cascade order. So, only parsing of the value is really required. Cascade becomes a bit more complex and, notably, elements withstyle
attribute creates new branches in the rules tree, thus decreasing the possibility of sharing. Given thatstyle
attribute declarations have higher precedence than style sheet declarations, they should be close to the leaves and this shouldn't be a big issue.Style.from()
still handles thestyle
attribute for elements that are not part of aDocument
(hence have no access to style sheet and no associated cascade). This should be mostly a use case for our own tests.