Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for mask CSS shorthand property #1711

Merged
merged 51 commits into from
Dec 12, 2024
Merged

Support for mask CSS shorthand property #1711

merged 51 commits into from
Dec 12, 2024

Conversation

rcj-siteimprove
Copy link
Contributor

@rcj-siteimprove rcj-siteimprove commented Nov 18, 2024

Support for mask CSS shorthand property and its longhands.

Longhands:

Shorthand:

Copy link

changeset-bot bot commented Nov 18, 2024

🦋 Changeset detected

Latest commit: dcaddde

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 78 packages
Name Type
@siteimprove/alfa-style Minor
@siteimprove/alfa-css Minor
@siteimprove/alfa-aria Minor
@siteimprove/alfa-rules Minor
@siteimprove/alfa-cascade Minor
@siteimprove/alfa-css-feature Minor
@siteimprove/alfa-dom Minor
@siteimprove/alfa-selector Minor
@siteimprove/alfa-act Minor
@siteimprove/alfa-affine Minor
@siteimprove/alfa-applicative Minor
@siteimprove/alfa-array Minor
@siteimprove/alfa-bits Minor
@siteimprove/alfa-branched Minor
@siteimprove/alfa-cache Minor
@siteimprove/alfa-callback Minor
@siteimprove/alfa-clone Minor
@siteimprove/alfa-collection Minor
@siteimprove/alfa-comparable Minor
@siteimprove/alfa-compatibility Minor
@siteimprove/alfa-continuation Minor
@siteimprove/alfa-device Minor
@siteimprove/alfa-earl Minor
@siteimprove/alfa-either Minor
@siteimprove/alfa-emitter Minor
@siteimprove/alfa-encoding Minor
@siteimprove/alfa-equatable Minor
@siteimprove/alfa-flags Minor
@siteimprove/alfa-fnv Minor
@siteimprove/alfa-foldable Minor
@siteimprove/alfa-functor Minor
@siteimprove/alfa-future Minor
@siteimprove/alfa-generator Minor
@siteimprove/alfa-graph Minor
@siteimprove/alfa-hash Minor
@siteimprove/alfa-http Minor
@siteimprove/alfa-iana Minor
@siteimprove/alfa-iterable Minor
@siteimprove/alfa-json-ld Minor
@siteimprove/alfa-json Minor
@siteimprove/alfa-lazy Minor
@siteimprove/alfa-list Minor
@siteimprove/alfa-map Minor
@siteimprove/alfa-mapper Minor
@siteimprove/alfa-math Minor
@siteimprove/alfa-monad Minor
@siteimprove/alfa-network Minor
@siteimprove/alfa-option Minor
@siteimprove/alfa-parser Minor
@siteimprove/alfa-performance Minor
@siteimprove/alfa-predicate Minor
@siteimprove/alfa-promise Minor
@siteimprove/alfa-record Minor
@siteimprove/alfa-rectangle Minor
@siteimprove/alfa-reducer Minor
@siteimprove/alfa-refinement Minor
@siteimprove/alfa-result Minor
@siteimprove/alfa-sarif Minor
@siteimprove/alfa-selective Minor
@siteimprove/alfa-sequence Minor
@siteimprove/alfa-set Minor
@siteimprove/alfa-slice Minor
@siteimprove/alfa-string Minor
@siteimprove/alfa-table Minor
@siteimprove/alfa-test-deprecated Minor
@siteimprove/alfa-test Minor
@siteimprove/alfa-thenable Minor
@siteimprove/alfa-thunk Minor
@siteimprove/alfa-time Minor
@siteimprove/alfa-toolchain Minor
@siteimprove/alfa-trampoline Minor
@siteimprove/alfa-tree Minor
@siteimprove/alfa-trilean Minor
@siteimprove/alfa-tuple Minor
@siteimprove/alfa-url Minor
@siteimprove/alfa-wcag Minor
@siteimprove/alfa-web Minor
@siteimprove/alfa-xpath Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rcj-siteimprove
Copy link
Contributor Author

!pr extract

@rcj-siteimprove rcj-siteimprove added minor Backwards-compatible change that touches public API Language support Related to unsupported features in HTML/CSS/ARIA labels Nov 28, 2024
@rcj-siteimprove rcj-siteimprove self-assigned this Nov 28, 2024
@rcj-siteimprove
Copy link
Contributor Author

!pr extract

@rcj-siteimprove rcj-siteimprove marked this pull request as ready for review December 9, 2024 14:57
@rcj-siteimprove rcj-siteimprove requested a review from a team as a code owner December 9, 2024 14:57
@rcj-siteimprove rcj-siteimprove changed the title Support for mask-* CSS properties Support for mask CSS shorthand property Dec 10, 2024
Copy link
Contributor

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉 Some improvements and polishing. Nothing really blocking.

packages/alfa-style/src/property/helpers/mask-layers.ts Outdated Show resolved Hide resolved
packages/alfa-style/src/property/helpers/mask-layers.ts Outdated Show resolved Hide resolved
packages/alfa-style/src/property/helpers/mask-layers.ts Outdated Show resolved Hide resolved
packages/alfa-style/src/property/mask-composite.ts Outdated Show resolved Hide resolved
packages/alfa-style/test/property/mask-clip.spec.tsx Outdated Show resolved Hide resolved
packages/alfa-style/test/property/mask-clip.spec.tsx Outdated Show resolved Hide resolved
packages/alfa-style/src/property/helpers/mask-layers.ts Outdated Show resolved Hide resolved
packages/alfa-style/src/property/helpers/mask-layers.ts Outdated Show resolved Hide resolved
packages/alfa-style/test/property/mask-position.spec.tsx Outdated Show resolved Hide resolved
@rcj-siteimprove
Copy link
Contributor Author

!pr extract

@rcj-siteimprove
Copy link
Contributor Author

!pr extract

@rcj-siteimprove
Copy link
Contributor Author

!pr extract

@rcj-siteimprove rcj-siteimprove added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 3a3e6e5 Dec 12, 2024
4 checks passed
@rcj-siteimprove rcj-siteimprove deleted the mask-properties branch December 12, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language support Related to unsupported features in HTML/CSS/ARIA minor Backwards-compatible change that touches public API
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

2 participants