New package alfa-painting-order
#1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 38bae09 The changes in this PR will be included in the next version bump. This PR includes changesets to release 80 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rcj-siteimprove
added
the
minor
Jym77
requested changes
Feb 11, 2025
packages/alfa-painting-order/src/predicate/is-flex-or-grid-child.ts
Outdated
Show resolved
Hide resolved
packages/alfa-painting-order/src/predicate/creates-stacking-context.ts
Outdated
Show resolved
Hide resolved
packages/alfa-painting-order/src/predicate/creates-stacking-context.ts
Outdated
Show resolved
Hide resolved
packages/alfa-painting-order/src/predicate/creates-stacking-context.ts
Outdated
Show resolved
Hide resolved
packages/alfa-painting-order/src/predicate/creates-stacking-context.ts
Outdated
Show resolved
Hide resolved
packages/alfa-painting-order/test/predicate/creates-stacking-context.spec.tsx
Outdated
Show resolved
Hide resolved
|
!pr extract |
|
!pr extract |
rcj-siteimprove
force-pushed
the
alfa-painting-order
branch
from
80231f8 to
36171a3
Compare
|
@Jym77 I addressed most of the comments, except two that I would like to look into in a follow up PR, but after the other work that depend on this one (using it to compute clickable area). |
Jym77
reviewed
Feb 19, 2025
Jym77
requested changes
Feb 19, 2025
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
|
!pr extract |
Jym77
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new package which contains functionality for computing the painting order of HTML elements based on the specification: https://drafts.csswg.org/css2/#painting-order.
The process for computing the painting order is fairly complex and that reflects in the implementation. This is the first step to make something that works in most common use cases. There are possibly room for caching some computations and other optimizations as well as making the algorithm easier to follow and less error-prone.
The current implementation does not consider scrolling frames, but that could be a logical next step if needed.
The painting order can be used for e.g. detecting if elements are fully or partially covered by other elements, which is relevant when determining the clickable area of an element. More on that in future PRs.