Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort out metrics #3

Open
Skepfyr opened this issue Feb 24, 2024 · 0 comments
Open

Sort out metrics #3

Skepfyr opened this issue Feb 24, 2024 · 0 comments

Comments

@Skepfyr
Copy link
Owner

Skepfyr commented Feb 24, 2024

This repo currently uses the metrics crate but I suspect the ecosystem will settle on opentelemetry, however a bigger problem is that emitting metrics directly from the load shedder is a bit weird because if you have mor ethan one they'll interfere with each other.

I think the options are:

  1. Stop emitting metrics (and instead allow more visibility into the state of the load shedder.
  2. Allow people to provide and identifier for the load shedder instance, allowing us to stick it into a label.

If anyone's reading this and want's to improve observability & metrics, then go ahead (although maybe leave your plan here first. I'm unlikkely to make this change as I don't actually use this library for anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant