Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Salmon Size Support #7177

Open
1 task done
APickledWalrus opened this issue Nov 1, 2024 · 0 comments
Open
1 task done

Salmon Size Support #7177

APickledWalrus opened this issue Nov 1, 2024 · 0 comments
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. PR available Issues which have a yet-to-be merged PR resolving it priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@APickledWalrus
Copy link
Member

APickledWalrus commented Nov 1, 2024 •
edited
Loading

Suggestion

In 1.21.2, two new salmon sizes were added: small and large. "medium" is the default size.
See: https://hub.spigotmc.org/javadocs/spigot/org/bukkit/entity/Salmon.Variant.html

An (non-simple) EntityData for salmon will need to be created. It should allow salmon, small salmon, medium salmon, and large salmon. When spawning just salmon, it should use no variant (default to whatever Bukkit does)

Why?

Skript should aim to support all features of an entity.

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this suggestion.
@APickledWalrus APickledWalrus added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). good first issue An issue that would be good for a first-time contributor to make a PR for labels Nov 1, 2024
@TheAbsolutionism TheAbsolutionism mentioned this issue Dec 1, 2024
Merged
@Efnilite Efnilite added PR available Issues which have a yet-to-be merged PR resolving it and removed good first issue An issue that would be good for a first-time contributor to make a PR for labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. PR available Issues which have a yet-to-be merged PR resolving it priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@APickledWalrus @Efnilite