Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClassInfo CodeName #7253

Open
1 task done
TheAbsolutionism opened this issue Dec 11, 2024 · 0 comments
Open
1 task done

ClassInfo CodeName #7253

TheAbsolutionism opened this issue Dec 11, 2024 · 0 comments
Assignees
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. PR available Issues which have a yet-to-be merged PR resolving it

Comments

@TheAbsolutionism
Copy link
Contributor

TheAbsolutionism commented Dec 11, 2024

Skript/Server Version

Any/All

Bug Description

When registering a ClassInfo with the singular codename ending with an i, Utils#getEnglishPlural() improperly marks it as plural and returns the codename with an us ending, even though it should be singular and not return with a different ending.
Causing Classes#getClassInfo() to throw a SkriptAPIException for an invalid/unregistered codename

Expected Behavior

The singular codename ending with an i not to be marked as plural.

Steps to Reproduce

Register a new ClassInfo with the singular codename ending in an i,
Make an element using the codename in the pattern as an expression,
Call the element and look at console

Errors or Screenshots

No response

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@Efnilite Efnilite added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Dec 20, 2024
@Moderocky Moderocky added the PR available Issues which have a yet-to-be merged PR resolving it label Dec 23, 2024
@Moderocky Moderocky self-assigned this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. PR available Issues which have a yet-to-be merged PR resolving it
Projects
None yet
Development

No branches or pull requests

3 participants