Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExprValueWithin and ExprEntities conflict #7280

Open
1 task done
sovdeeth opened this issue Dec 19, 2024 · 0 comments
Open
1 task done

ExprValueWithin and ExprEntities conflict #7280

sovdeeth opened this issue Dec 19, 2024 · 0 comments
Labels
2.10 Targeting a 2.10.X version release bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. up for debate When the decision is yet to be debated on the issue in question

Comments

@sovdeeth
Copy link
Member

Skript/Server Version

[22:22:13 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[22:22:13 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[22:22:13 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[22:22:13 INFO]: [Skript] Server Version: 1.21.3-27-661839e (MC: 1.21.3)
[22:22:13 INFO]: [Skript] Skript Version: 2.9.5 (selfbuilt-unknown) (also reported on 2.9.2)
[22:22:13 INFO]: [Skript] Installed Skript Addons:
[22:22:13 INFO]: [Skript]  - skript-reflect v2.5.1 (https://github.com/SkriptLang/skript-reflect)
[22:22:13 INFO]: [Skript]  - SkBee v3.6.1 (https://github.com/ShaneBeee/SkBee)
[22:22:13 INFO]: [Skript] Installed dependencies: None

Bug Description

When using loop entities within {_a} and {_b}, it is parsed as loop (entities within ({_a} and {_b})) using ExprValueWithin rather than ExprEntities and loop (entities within {_a} and {_b})

This, however, can be avoided by using loop all entities within {_a} and {_b} to force ExprEntities

Expected Behavior

Who should get priority is debatable, but I think ExprEntities is the much more common usecase and should take priority. That said, it would make using ExprValueWithin much harder on two variables. Perhaps it should be left as is.

Steps to Reproduce

loop entities within {_a} and {_b} run under debug verbosity shows the issue.

Errors or Screenshots

image
image

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@sovdeeth sovdeeth added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. up for debate When the decision is yet to be debated on the issue in question 2.10 Targeting a 2.10.X version release labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.10 Targeting a 2.10.X version release bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. up for debate When the decision is yet to be debated on the issue in question
Projects
None yet
Development

No branches or pull requests

1 participant