Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for the wallet #10

Open
5 of 9 tasks
Senyoret1 opened this issue Jul 6, 2020 · 1 comment
Open
5 of 9 tasks

Improvements for the wallet #10

Senyoret1 opened this issue Jul 6, 2020 · 1 comment

Comments

@Senyoret1
Copy link

Senyoret1 commented Jul 6, 2020

This is a list with changes that would improve the UI and UX of the wallet (some of the changes would also apply for the desktop wallet in the main Skycoin repo):

  • Allow to configure the confirmations needed: the wallet UI should allow the user to configure how many confirmations to wait for before considering a transaction fully confirmed.

  • Improve the form validations: currently the forms have a validation procedure which disables the action button if there is an error, but no information is given to the user about were the problems are, which may end being confusing in some cases, specially for new users. The form should clearly inform were the errors are.

  • Add an option for increasing the fee of the pending ETH and BTC transactions: if a user sends a transaction paying a very low fee, the transaction may stay unconfirmed for a very long time. It would be good to add an option for replacing the transaction with another one with a higher fee, to make sure the transaction is processed. This should be done after BTC and ETH transactions are working correctly.

  • Make the decimals look different: currently it is difficult to see the difference between amounts like 1,001 and 1.001. To solve this, the decimal part of the number should be a bit different. An option would be to make the decimal part a bit transparent.

  • Use the guided method for entering seeds in the page for restoring the password: currently the wallet uses a guided method for allowing the user to enter the seed when creating or restoring a wallet. That method allowed to prevent constant errors reported by the users. However, the guided method is not available in the page for restoring the password, and it should be.

  • Use a better button for allowing to enter custom seeds: there have been multiple reports of users not knowing how to enter a custon seed (without using the guided method). The button for entering a custom seed should be replaced with something more evident.

  • Show the burned hours in the history page: this may work like in the mobile wallet.

  • Add compatibility with the URL scheme: currently the desktop and mobile wallets allow to create QR codes and links using BIP21, but the desktop wallet is not able to do anything with them. There are 2 types of compatibility that can be added to the desktop wallet: a button in the send coins form which would allow the user to paste the link to populate the form with the contents, and making the Electron version to be openned and process the links when the user clicks one of them (which is the default behavior for other wallets).

This is a list with internal improvements:

  • Remove the duplicate code in the operators: the wallet contains special objects called "operators" for processing coin specific data. These objects were created in a very generic way to make them very flexible when connecting to different backends, which was important to avoid problems. However, after implementing other coins there is more clarity about which parts of the code need that flexibility and which parts are the same for all coins. Because of this, the repeated parts should be removed and the functionalities centraliced, as there is currently a lot of repeated code which makes everything harder to maintain.
@Senyoret1
Copy link
Author

This is a design idea for making the decimals look different:
dcw
In the image coin values have decimals while coin hour values don't. Looking at the coin values it is easy to differentiate the decimal parts, while in the coin hours values it would be difficult if there were decimals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant