Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use skygear.settings for reading configuration #5

Open
rickmak opened this issue Sep 28, 2016 · 1 comment
Open

Use skygear.settings for reading configuration #5

rickmak opened this issue Sep 28, 2016 · 1 comment

Comments

@rickmak
Copy link
Member

rickmak commented Sep 28, 2016 •
edited by chpapa
Loading

No description provided.

rickmak added a commit to rickmak/forgot_password that referenced this issue Sep 28, 2016
@rickmak
Convert to use skygear.settings
40673ee 
refs SkygearIO#5
rickmak added a commit to rickmak/forgot_password that referenced this issue Sep 28, 2016
@rickmak
Use settings to determine register to skygear or not
c4221d0 
Take away the assumption on register on import, which give more
flexibility on how the plugin to be deploy

refs SkygearIO#5
rickmak added a commit to rickmak/forgot_password that referenced this issue Sep 29, 2016
@rickmak
Use settings to determine register to skygear or not
265055c 
Take away the assumption on register on import, which give more
flexibility on how the plugin to be deploy

refs SkygearIO#5
ben181231 pushed a commit to ben181231/forgot_password that referenced this issue Oct 20, 2016
Use skygear settings for reading configuration
070d2b7 
Ref. SkygearIO#5
@ben181231 ben181231 mentioned this issue Oct 20, 2016
Merged
ben181231 pushed a commit to ben181231/forgot_password that referenced this issue Oct 20, 2016
Use skygear settings for reading configuration
1e7c9e7 
Ref. SkygearIO#5
rickmak added a commit that referenced this issue Oct 25, 2016
@rickmak
Update to use new plugin init mechanism
0a76b23 
refs SkygearIO/py-skygear#70
refs #5
@rickmak
Copy link
Member Author

rickmak commented Nov 3, 2016

Incorrect use of settings. The settings should be import from skygear package, not passing around.

@rickmak rickmak reopened this Nov 3, 2016
@royuen royuen assigned cheungpat and unassigned ben181231 Feb 13, 2017
@rickmak rickmak self-assigned this Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rickmak @cheungpat @royuen @chpapa @ben181231