We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The generated URL should always be valid.
https://s3.amazonaws.com/<bucket>/<object-name>
https://s3-us-east-1.amazonaws.com/<bucket>/<object-name>
us-east-1
ASSET_STORE_PUBLIC=YES
skygear.asset.get_signer().sign(some_asset_id)
When ASSET_STORE_PUBLIC=YES, we naively concat the region to build the URL. The valid format is documented here
Use ASSET_STORE_S3_URL_PREFIX=https://s3.amazonaws.com/<bucket>
ASSET_STORE_S3_URL_PREFIX=https://s3.amazonaws.com/<bucket>
The text was updated successfully, but these errors were encountered:
Fix S3 generates incorrect url for us-east-1
7cd6d22
refs SkygearIO#191
0f2b95b
cheungpat
No branches or pull requests
Expected Results
The generated URL should always be valid.
Actual Results
Steps to reproduce
us-east-1
ASSET_STORE_PUBLIC=YES
skygear.asset.get_signer().sign(some_asset_id)
Cause
When
ASSET_STORE_PUBLIC=YES
, we naively concat the region to build the URL. The valid format is documented hereWorkaround
Use
ASSET_STORE_S3_URL_PREFIX=https://s3.amazonaws.com/<bucket>
The text was updated successfully, but these errors were encountered: