Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SERVE_STATIC_ASSETS=true should support public_html #428

Open
cheungpat opened this issue Jun 11, 2018 · 1 comment
Open

SERVE_STATIC_ASSETS=true should support public_html #428

cheungpat opened this issue Jun 11, 2018 · 1 comment
Labels

Comments

@cheungpat
Copy link
Contributor

Since #125, the public_html directory is not served when SERVE_STATIC_ASSETS is turned on. This should be supported to have feature parity with py-skygear.

@iam7seven7
Copy link

iam7seven7 commented Jan 10, 2019

I realize this is why I can't serve static assets with public_html on my machine but works fine on skygeario. Thanks Rick for troubleshooting.

My workaround is to place assets in a subfolder in public_html, and declare static asset path:

skygearCloud.staticAsset("/client", () => {
  return path.resolve(__dirname, "./public_html/client");
});

This will only take effect on local machine. (skygearCloud.staticAsset is override on skygeario)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants