Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Epic Fight? Tools Missing Tags #5301

Open
ssbgross opened this issue Jan 10, 2025 · 1 comment
Open

Compatibility with Epic Fight? Tools Missing Tags #5301

ssbgross opened this issue Jan 10, 2025 · 1 comment
Labels
1.20 Issue affects 1.20 Enhancement Issue or pull request addresses a change to an existing functional feature Not enough information Insufficient information is provided in the issue to accurately respond

Comments

@ssbgross
Copy link

Minecraft Version

1.20.1

Forge Version

47.3.22

Mantle Version

1.11.28

Tinkers' Construct Version

3.9.0.6

Problem description

I am currently working on a modpack for a couple friends and myself. I am using Epic Fight as the main combat overhaul of the pack. Most mods I've tested have automatically worked with Epic Fight, even if it is just the normal sword attack. However, every tool in this mod has automatically assumed the stance of "fist" in Epic Fight. So, I assume that none of them are tagged as tools or swords or the like.

Suggested solution

I believe that if you were to tag the tools as being "One Handed" or "Two Handed" instead of empty, Epic Fight would automatically register that as the correct type and display the proper animation, rather than have me fight with my fists.

Alternatives considered

I have made my own datapack for compatability with other mods, but to make an individual compat file for every tool in this mod would take me a long time. I don't think this is all that necessary anyways, as it might be faster for you to tag them in development.

Additional context

I would also like to state that, in accordance with your FAQ, I believe that having your tools and weapons appropriately tagged might help other mods not just Epic Fight. I say this as mods such as Cataclysm, Alex's Mobs/Caves, Mowzie's Mobs, Simply Swords, and Iron's Spellbooks all have immediate partial compatibility because their weapons and tools are tagged as "One Handed."

Searched for existing enhancement?

Used the search bar, Checked the FAQ

@ssbgross ssbgross added 1.20 Issue affects 1.20 Enhancement Issue or pull request addresses a change to an existing functional feature Unreviewed Issue is new and is awaiting the team to review it labels Jan 10, 2025
@KnightMiner
Copy link
Member

People have created datapacks with epic fight before, always end up finding many of our modifiers don't work. You need a proper addon to add compatibility, not just a few tags.

Also, if you are going to suggest tags, tell me what actual tags you want. "One handed" tells me nothing

@KnightMiner KnightMiner added Not enough information Insufficient information is provided in the issue to accurately respond and removed Unreviewed Issue is new and is awaiting the team to review it labels Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20 Issue affects 1.20 Enhancement Issue or pull request addresses a change to an existing functional feature Not enough information Insufficient information is provided in the issue to accurately respond
Projects
None yet
Development

No branches or pull requests

2 participants