Books and player heads metadata copy/dupe

[CoolFido]

❗ Checklist

• I am using the official english version of Slimefun and did not modify the jar.
• I am using an up to date "DEV" (not "RC") version of Slimefun.
• I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
• I searched for similar open issues and could not find an existing bug report on this.

📍 Description

If you connect two chests via Cargo Nodes, you can copy metadata of signed books and player heads from one to another, resulting in, for example, duplication of "cheque" books, or other valuable books or heads.

📑 Reproduction Steps

1. Have two signed books (A and B).
2. Place these blocks (listed from left to right, but placement order does not matter, appaerently):
   • Chest,
   • Cargo Node (Input),
   • Cargo Manager
   • Cargo Node (Output),
   • Chest.
3. Set the Cargo Node (Input) type to Blacklist.
4. Insert the book to be copied (A) into the right (output) chest.
5. Insert the other book (B) into the left (input) chest.
6. In the right chest you will have the copied book (A) two times.

The same applies to player heads.

Also it works for higher quantities of items: for example, if you were to fill the right chest with the A books, and then proceed to insert some B books into the left chest, the item stacks in the right chest will all get eventually filled up.

On the other hand, if you would only have 1 A book in the right chest and you were to put 17 B books into the left chest, you would end up with 16 A books and 2 B books in the right chest. So the issue is clearly linked to incomplete item stacks.

💡 Expected Behavior

I would expect the B book to transfer to the right (output) chest, instead of getting another A book.

📷 Screenshots / Videos

See the bug reproduction process screencap: https://ctrlv.tv/ZLMh

📜 Server Log

No response

📂 /error-reports/ folder

No response

💻 Server Software

Paper

🎮 Minecraft Version

1.17.x

⭐ Slimefun version

Tested on:

This Server uses the following setup of Slimefun:
Paper git-Paper-411 (MC: 1.17.1)
Slimefun RC - 35 (git 5e901972)
Metrics-Module #29
Java 17
Installed Addons: (2)
  CMILib v1.2.5.3
  CMI v9.2.1.1

,

This Server uses the following setup of Slimefun:
Paper git-Paper-411 (MC: 1.17.1)
Slimefun DEV - 1104 (git c977454e)
Metrics-Module #29
Java 17
Installed Addons: (2)
  CMILib v1.2.5.3
  CMI v9.2.1.1

and:

This Server uses the following setup of Slimefun:
Paper git-Paper-81 (MC: 1.19)
Slimefun RC - 35 (git 5e901972)
Metrics-Module #29
Java 17
Installed Addons: (14)
  DyedBackpacks vDEV - 17 (git 8b329e96)
  Residence v5.0.2.0
  EcoPower vDEV - 5 (git 5c1ecd68)
  HotbarPets vDEV - 38 (git fa6c871d)
  ExoticGarden vDEV - 78 (git 7f9a5f63)
  InfinityExpansion vDEV - 144 (git 9da37202)
  ElectricSpawners vDEV - 23 (git 6ec96773)
  LiteXpansion vDEV - 192 (git 661862ed)
  SoulJars vDEV - 24 (git 78d1c6fa)
  SlimyTreeTaps vDEV - 20 (git 963f0383)
  PrivateStorage vDEV - 18 (git 5832db21)
  FluffyMachines vDEV - 132 (git ccf029ba)
  CMI v9.6.0.7
  Core v1.0

🧭 Other plugins

No response

[Boomer-1]

before anything can be done you must update to the latest dev version. once you do, i believe this issue will be resolved. I'll keep this open for a couple days to give you time to update and confirm

[CoolFido]

@Boomer-1

before anything can be done you must update to the latest dev version. once you do, i believe this issue will be resolved. I'll keep this open for a couple days to give you time to update and confirm

As of right now, accroding to the download page the latest dev version is: 09 Oct 2023 (18:54:31) #c9774.

As you can see in my issue, the versions that feature the described bug do include the version Slimefun DEV - 1104 (git c977454e), which also is the version used in the attached screencapture.

[Boomer-1]

the screenshots you provided show you are using RC35 which is nearly a year old. you must update to 1104

[CoolFido]

the screenshots you provided show you are using RC35 which is nearly a year old. you must update to 1104

?

https://ctrlv.tv/ZLMh @ 0:07:

[Boomer-1]

and you've been able to replicate this on 1104?

[CoolFido]

#4020 (comment)

As you can see in my issue, THE VERSIONS THAT FEATURE THE DESCRIBED BUG
D O
I N C L U D E
THE VERSION Slimefun DEV - 1104 (git c977454), which also is the version used in the attached screencapture.

[Boomer-1]

It's ok I was able to replicate it.

[PriestOfTerror]

Please correct this error. has persisted for a long time and affects a large portion of slimefun, rendering it unusable.

[MineHubPruvodce]

Please correct this error. has persisted for a long time and affects a large portion of slimefun, rendering it unusable.

[Boomer-1]

the devs are aware but are working on much more significant issues atm.

[croudom10]

Haven't been able to replicate with player heads on 1149. Books are still copied however.

[Smeja64]

It seems to me that SlimeFun doesn't check the books' metas at all and instead returns true when the ItemMeta is not an instance of PotionMeta.

@ https://github.com/Slimefun/Slimefun4/blob/master/src/main/java/io/github/thebusybiscuit/slimefun4/utils/SlimefunUtils.java#L489

I went through the code of the Cargo Output Node with the help of the sf debug command and this is where I ended up at.

Debug logs

[22:43:10 INFO]: Smeja64 issued server command: /sf debug slimefun_cargo_input_testing
[22:44:24 INFO]: [Slimefun] [DEBUG slimefun_cargo_input_testing] ItemFilter#test(ItemStack{WRITTEN_BOOK x 1, BOOK_SIGNED_META:{meta-type=BOOK_SIGNED, title=Another one, author=Smeja64, pages=["dolor sit amet"], resolved=true}})
[22:44:24 INFO]: [Slimefun] [DEBUG slimefun_cargo_input_testing] CargoUtils#insert
[22:44:24 INFO]: [Slimefun] [DEBUG slimefun_cargo_input_testing] ItemFilter#test(ItemStack{WRITTEN_BOOK x 1, BOOK_SIGNED_META:{meta-type=BOOK_SIGNED, title=Another one, author=Smeja64, pages=["dolor sit amet"], resolved=true}})
[22:44:26 INFO]: [Slimefun] [DEBUG slimefun_cargo_input_testing] ItemFilter#test(ItemStack{WRITTEN_BOOK x 1, BOOK_SIGNED_META:{meta-type=BOOK_SIGNED, title=A great tale, author=Smeja64, pages=["lorem ipsum"], resolved=true}})
[22:44:26 INFO]: [Slimefun] [DEBUG slimefun_cargo_input_testing] CargoUtils#insert
[22:44:26 INFO]: [Slimefun] [DEBUG slimefun_cargo_input_testing] ItemFilter#test(ItemStack{WRITTEN_BOOK x 1, BOOK_SIGNED_META:{meta-type=BOOK_SIGNED, title=A great tale, author=Smeja64, pages=["lorem ipsum"], resolved=true}})
[22:44:26 INFO]: [Slimefun] [DEBUG slimefun_cargo_input_testing] SlimefunUtils#isItemSimilar - item.hasItemMeta()
[22:44:26 INFO]: [Slimefun] [DEBUG slimefun_cargo_input_testing]   is wrapper
[22:44:26 INFO]: [Slimefun] [DEBUG slimefun_cargo_input_testing]   sfitem is ItemStackWrapper - possible SF Item: ItemStack{WRITTEN_BOOK x 1, BOOK_SIGNED_META:{meta-type=BOOK_SIGNED, title=A great tale, author=Smeja64, pages=["lorem ipsum"], resolved=true}}
[22:44:26 INFO]: [Slimefun] [DEBUG slimefun_cargo_input_testing]   Item IDs don't match, checking meta BOOK_SIGNED_META:{meta-type=BOOK_SIGNED, title=Another one, author=Smeja64, pages=["dolor sit amet"], resolved=true} == BOOK_SIGNED_META:{meta-type=BOOK_SIGNED, title=A great tale, author=Smeja64, pages=["lorem ipsum"], resolved=true} (lore: true)

Path I took inspecting the code

• educated guess of CargoUtils.insert(CargoUtils.java:248),
• call to CargoUtils.insertIntoVanillaInvenoty(CargoUtils.java:315) at line 269
• call to SlimefunUtils.isItemSimilar(SlimefunUtils.java:311) at line 345
• call to SlimefunUtils.isItemSimilar(SlimefunUtils.java:334) at line 312
• call to SlimefunUtils.equalsItemMeta(SlimefunUtils.java:461) at line 413 (this is where the debug log ends - at line 412)
• in there then every check returns false except the one checking whether any of the compared ItemMetas is other ItemMeta than PotionMeta (which the BookMeta clearly is)

I look forward to this issue getting resolved. Please tell me if I can be of any help or if I've made a mistake somewhere.

[Smeja64]

Haven't been able to replicate with player heads on 1149. Books are still copied however.

I reproduced it with player heads just now as well. When I gave myself a skull with my skin and tried to dupe it by using an empty one, it didn't work, neither it did when I renamed the empty one to have the same name. But when I gave myself another skull with another player's skin, I was able to rewrite its metadata just as well as I could with the signed books.