Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Books and player heads metadata copy/dupe #4020

Open
4 tasks done
CoolFido opened this issue Nov 9, 2023 · 11 comments · May be fixed by #4193
Open
4 tasks done

Books and player heads metadata copy/dupe #4020

CoolFido opened this issue Nov 9, 2023 · 11 comments · May be fixed by #4193
Labels
🐞 Bug Report A bug that needs to be fixed. 🧨 Confirmed Bug This bug has been confirmed by our team.

Comments

@CoolFido
Copy link

CoolFido commented Nov 9, 2023

❗ Checklist

  • I am using the official english version of Slimefun and did not modify the jar.
  • I am using an up to date "DEV" (not "RC") version of Slimefun.
  • I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
  • I searched for similar open issues and could not find an existing bug report on this.

📍 Description

If you connect two chests via Cargo Nodes, you can copy metadata of signed books and player heads from one to another, resulting in, for example, duplication of "cheque" books, or other valuable books or heads.

📑 Reproduction Steps

  1. Have two signed books (A and B).
  2. Place these blocks (listed from left to right, but placement order does not matter, appaerently):
    • Chest,
    • Cargo Node (Input),
    • Cargo Manager
    • Cargo Node (Output),
    • Chest.
  3. Set the Cargo Node (Input) type to Blacklist.
  4. Insert the book to be copied (A) into the right (output) chest.
  5. Insert the other book (B) into the left (input) chest.
  6. In the right chest you will have the copied book (A) two times.

The same applies to player heads.

Also it works for higher quantities of items: for example, if you were to fill the right chest with the A books, and then proceed to insert some B books into the left chest, the item stacks in the right chest will all get eventually filled up.

On the other hand, if you would only have 1 A book in the right chest and you were to put 17 B books into the left chest, you would end up with 16 A books and 2 B books in the right chest. So the issue is clearly linked to incomplete item stacks.

💡 Expected Behavior

I would expect the B book to transfer to the right (output) chest, instead of getting another A book.

📷 Screenshots / Videos

See the bug reproduction process screencap: https://ctrlv.tv/ZLMh

📜 Server Log

No response

📂 /error-reports/ folder

No response

💻 Server Software

Paper

🎮 Minecraft Version

1.17.x

⭐ Slimefun version

Tested on:

This Server uses the following setup of Slimefun:
Paper git-Paper-411 (MC: 1.17.1)
Slimefun RC - 35 (git 5e901972)
Metrics-Module #29
Java 17
Installed Addons: (2)
  CMILib v1.2.5.3
  CMI v9.2.1.1

,

This Server uses the following setup of Slimefun:
Paper git-Paper-411 (MC: 1.17.1)
Slimefun DEV - 1104 (git c977454e)
Metrics-Module #29
Java 17
Installed Addons: (2)
  CMILib v1.2.5.3
  CMI v9.2.1.1

and:

This Server uses the following setup of Slimefun:
Paper git-Paper-81 (MC: 1.19)
Slimefun RC - 35 (git 5e901972)
Metrics-Module #29
Java 17
Installed Addons: (14)
  DyedBackpacks vDEV - 17 (git 8b329e96)
  Residence v5.0.2.0
  EcoPower vDEV - 5 (git 5c1ecd68)
  HotbarPets vDEV - 38 (git fa6c871d)
  ExoticGarden vDEV - 78 (git 7f9a5f63)
  InfinityExpansion vDEV - 144 (git 9da37202)
  ElectricSpawners vDEV - 23 (git 6ec96773)
  LiteXpansion vDEV - 192 (git 661862ed)
  SoulJars vDEV - 24 (git 78d1c6fa)
  SlimyTreeTaps vDEV - 20 (git 963f0383)
  PrivateStorage vDEV - 18 (git 5832db21)
  FluffyMachines vDEV - 132 (git ccf029ba)
  CMI v9.6.0.7
  Core v1.0

🧭 Other plugins

No response

@CoolFido CoolFido added 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. 🐞 Bug Report A bug that needs to be fixed. labels Nov 9, 2023
@Boomer-1
Copy link

Boomer-1 commented Nov 9, 2023

before anything can be done you must update to the latest dev version. once you do, i believe this issue will be resolved. I'll keep this open for a couple days to give you time to update and confirm

@CoolFido
Copy link
Author

CoolFido commented Nov 9, 2023

@Boomer-1

before anything can be done you must update to the latest dev version. once you do, i believe this issue will be resolved. I'll keep this open for a couple days to give you time to update and confirm

As of right now, accroding to the download page the latest dev version is: 09 Oct 2023 (18:54:31) #c9774.

As you can see in my issue, the versions that feature the described bug do include the version Slimefun DEV - 1104 (git c977454e), which also is the version used in the attached screencapture.

@Boomer-1
Copy link

Boomer-1 commented Nov 9, 2023

the screenshots you provided show you are using RC35 which is nearly a year old. you must update to 1104

@CoolFido
Copy link
Author

CoolFido commented Nov 9, 2023

the screenshots you provided show you are using RC35 which is nearly a year old. you must update to 1104

?

https://ctrlv.tv/ZLMh @ 0:07:
obrazek

@Boomer-1
Copy link

Boomer-1 commented Nov 9, 2023

and you've been able to replicate this on 1104?

@CoolFido
Copy link
Author

CoolFido commented Nov 9, 2023

#4020 (comment)

As you can see in my issue, THE VERSIONS THAT FEATURE THE DESCRIBED BUG
D O
I N C L U D E
THE VERSION Slimefun DEV - 1104
(git c977454), which also is the version used in the attached screencapture.

@Boomer-1 Boomer-1 added 🧨 Confirmed Bug This bug has been confirmed by our team. and removed 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. labels Nov 9, 2023
@Boomer-1
Copy link

Boomer-1 commented Nov 9, 2023

It's ok I was able to replicate it.

@PriestOfTerror
Copy link

Please correct this error. has persisted for a long time and affects a large portion of slimefun, rendering it unusable.

1 similar comment
@MineHubPruvodce
Copy link

Please correct this error. has persisted for a long time and affects a large portion of slimefun, rendering it unusable.

@Boomer-1
Copy link

the devs are aware but are working on much more significant issues atm.

Dinnerwolph added a commit to Dinnerwolph/Slimefun4 that referenced this issue May 20, 2024
@Dinnerwolph Dinnerwolph linked a pull request May 20, 2024 that will close this issue
7 tasks
@croudom10
Copy link

croudom10 commented Aug 24, 2024

Haven't been able to replicate with player heads on 1149. Books are still copied however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug Report A bug that needs to be fixed. 🧨 Confirmed Bug This bug has been confirmed by our team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants