Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed tabs keep playing video in background #558

Open
YOEL-44 opened this issue Oct 4, 2023 · 12 comments
Open

Closed tabs keep playing video in background #558

YOEL-44 opened this issue Oct 4, 2023 · 12 comments
Labels
bug Something isn't working cannot reproduce

Comments

@YOEL-44
Copy link

YOEL-44 commented Oct 4, 2023

Description

Whenever you close a tab without previously stopping all of the videos in that page, whatever was playing back will continue even after completelly closing Fulguris, making force stopping the whole app the only fix.

Environment

  • Device: Xiaomi Mi Max 3
  • OS: Android 10 (RROS 8.7.3)
  • Version: I think every version, this has been going on for years (I got used to prevent it, that's why I didn't report, sorry)

To reproduce

Steps to reproduce the behaviour:

  1. Go to any web page with an inserted video player
  2. Click on play
  3. Close the tab where the video is playing or close the browser
  4. You should still hear the video playing, it might stutter, but otherwise it will continue indefinitely.

Expected behaviour

The video should stop streaming only when the tab or Fulguris itself is closed, it should continue if you're only changing from one tab to another or changing apps without closing Fulguris.

Screenshots

The feedback comes from the sound so...

Additional context

I've been searching older bugs and festure requests and a user with a Samsung device was specially concerned with keeping the video alive when multitasking, so the fix for the issue I mention should be applied with that consideration.

@Slion
Copy link
Owner

Slion commented Oct 4, 2023

Is there a URL you could share?

@YOEL-44
Copy link
Author

YOEL-44 commented Oct 5, 2023

Is there a URL you could share?

Hmm... I tried with the same video of the same webpage and the same browser settings it did it for me the last time, but this time it stopped correctly, maybe there is some kind of setup for the bug to occur...
I had some other tabs opened in the background when it happened, maybe those where keeping the recently closed one alive?
Anyway, the last time it was with this webpage:
https://www.lasexta.com/viajestic/curioso/video-viral-azafata-gritando-pasajero-hacer-llorar-resto-tripulacion_2023011963c91ff8f0501d000137a08a.html

@Slion
Copy link
Owner

Slion commented Oct 6, 2023

Thanks, I can't reproduce it either. Looks like this is going to be an elusive bug.

@Slion Slion added the bug Something isn't working label Oct 8, 2023
@jodo13
Copy link

jodo13 commented Nov 29, 2023

Despite is not a video, maybe this example can help you to track it down, if it is based on the same issue @Slion

If you go to this obituary page, it starts playing a music after a few seconds:
https://www.tanatoriosirache.es/es/despedimos.html

If you close/swipe out the tab, the music keeps playing.

As far as I have tested it continues and continues until you go to a bookmark or load a new page on another tab.

Sometimes, this happened more earlier than now, it continues playing until you close Fulguris.

This is quite annoying as, well, is an obituary music, and I don't have to waste resources on playing it nor hear it while reading another page in another tab.

@bogdan-the-great
Copy link

Hi! In my case this "feature" is useful when trying to play videos in the background from Invidious. I just refresh the page and go to another, then it plays the selected video in the background. I think this could lead to an implementation of background play for Fulguris.

Huawei WAS-LX1, Android 11, v1.9.17 from fdroid

@Slion
Copy link
Owner

Slion commented Jan 21, 2024

Background play should really be implemented at some point. However this bug ought to be fixed.

@Slion
Copy link
Owner

Slion commented Feb 2, 2024

just refresh the page and go to another, then it plays the selected video in the background

Can't reproduce that on Honor Magic V2 Android 13. For me it only starts playing the video when I switch back to that tab.
I could however reproduce it twice on Windows 11. Looks like it's very much timing dependent. Might be easier to reproduce on slower CPU.

@Slion
Copy link
Owner

Slion commented Feb 2, 2024

If you go to this obituary page, it starts playing a music after a few seconds:
https://www.tanatoriosirache.es/es/despedimos.html

If you close/swipe out the tab, the music keeps playing.

For me the music keeps playing in the background when I switch to another tab but when I close the tab it stops.

@jodo13
Copy link

jodo13 commented Feb 4, 2024

If you go to this obituary page, it starts playing a music after a few seconds:
https://www.tanatoriosirache.es/es/despedimos.html

If you close/swipe out the tab, the music keeps playing.

For me the music keeps playing in the background when I switch to another tab but when I close the tab it stops.

And I guess you mean that leave it open in the background. That, I guess, should be normal.

Let's explain the simple scenario again:

I always open and close Fulguris with two empty tabs (one is a background one and the other the actively used one (Why this? you'll ask, because I don't like the behavior of Fulguris of restoring the last visited site, despite you closed/swipe that tab to close fulguris, so I always use the "active tab" and leave the other behind so if I close this one, the left one is empty and doesn't load the latest page, but this is another issue (and I think it is still open in the tracker); I'm just telling this to get you into details)).

If I use the active tab and I open the above url, in a few X seconds the music starts playing.

You review the site, and after that, I go to the tab list and I close/swipe it. Why close?, why not?

After that, without doing anything else, the music continues playing.

Do you minimize it? Still playing.

Do you open an empty tab. Keeps playing.

Now, until you load something in a new tab or the playing tab, the music doesn't stop.

Or let's open a bookmarks now (I setup it to open in a new tab) on load of this new page, the music finally stops.

Desired behavior:
If you don't intentionally leave the tab open, it shouldn't play anything.

Maybe it doesn't play forever, but should stop upon close.

I think I covered all the scenarios it happens... to me, with the latest version.

@Slion
Copy link
Owner

Slion commented Feb 4, 2024

And I guess you mean that leave it open in the background. That, I guess, should be normal.

  • I do not know if it is normal that background music keeps playing when the tab is in the background
  • I could not reproduce your issue. Once I close the tab playing the music it stops playing it.

@jodo13
Copy link

jodo13 commented Feb 26, 2024

Sorry to not reply back earlier, I didn't forget about it, but as of:

  • could not reproduce your issue. Once I close the tab playing the music it stops playing it.

I only can say that might be system specific, but, then, so, from there I can't help further either. It is way beyond of a simple user.

I just felt I owed a reply.

Regards.

@Slion
Copy link
Owner

Slion commented Feb 27, 2024

While investigating this I came across #608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cannot reproduce
Projects
None yet
Development

No branches or pull requests

4 participants