Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: add an optional "label" to a wallet #509

Open
freak12techno opened this issue Sep 17, 2024 · 2 comments
Open

Idea: add an optional "label" to a wallet #509

freak12techno opened this issue Sep 17, 2024 · 2 comments

Comments

@freak12techno
Copy link
Contributor

freak12techno commented Sep 17, 2024

In chainsRelayed, there's an array of objects, each having a ticker and a relayerAddress fields.
I think it would be nice to allow specifying some kind of a label/alias identifying this wallet.

My use case: so I am running 2 relayers, one with Hermes and one with rly, using different wallets.
When I go to the UI, I see something like this:
image
and without using the external data it's unclear which wallet is used by which relayer.

I propose doing the following:

  1. adding the optional alias (or something similar) field to an entity in chainsRelayed
  2. in UI, changing the text of the "Address" link to display either alias, if it's present, or relayerAddress if not (while the link should still lead to the wallet from relayerAddress field).

Should be pretty backwards-compatible this way.

What do you think?

@SmartStake
Copy link
Owner

Great idea. Agreed on adding it to the json object.

As you alluded to on the UI side, Smart stake works exactly like that. It has the concept of aliases in some of the other analytics/richlists. It shows alias in place of address where alias is present but the copy button (and perhaps hover/tooltip can still show address).

will add to todo and rollout shortly. thanks for the suggestions.

@freak12techno
Copy link
Contributor Author

Btw, on json object: I suggest adding a JSON schema and a CI action to validate it (this goes out of scope of this issue for sure, but just a thought it'd be nice)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants