Remove OPTIONAL_SUPPORTED_COMPONENT_CAPABILITIES field

Compare the newly generated component capabilities list against the
current device profile rather than saving this information in a
persisted field.

Author: nickolas-deboom

drivers/SmartThings/matter-switch/src/sub_drivers/camera/init.lua

@@ -28,7 +28,6 @@ local MAX_ENCODED_PIXEL_RATE = "__max_encoded_pixel_rate"
 local MAX_FRAMES_PER_SECOND = "__max_frames_per_second"
 local MAX_VOLUME_LEVEL = "__max_volume_level"
 local MIN_VOLUME_LEVEL = "__min_volume_level"
-local OPTIONAL_SUPPORTED_COMPONENT_CAPABILITIES = "__optional_supported_component_capabilities"
 local SUPPORTED_RESOLUTIONS = "__supported_resolutions"
 local TRIGGERED_ZONES = "__triggered_zones"
 local VIEWPORT = "__viewport"
@@ -258,21 +257,29 @@ local function compare_components(synced_components, prev_components)
   return true
 end
 
-local function compare_optional_capabilities(optional_capabilities, prev_optional_capabilities)
+local function optional_capabilities_list_changed(optional_capabilities, prev_component_list)
+  local prev_optional_capabilities = {}
+  for idx, comp in pairs(prev_component_list or {}) do
+    local cap_list = {}
+    for _, capability in pairs(comp.capabilities) do
+      table.insert(cap_list, capability.id)
+    end
+    table.insert(prev_optional_capabilities, {idx, cap_list})
+  end
   if #optional_capabilities ~= #prev_optional_capabilities then
-    return false
+    return true
   end
   for _, capability in pairs(optional_capabilities) do
     if not switch_utils.tbl_contains(prev_optional_capabilities, capability) then
-      return false
+      return true
     end
   end
   for _, capability in pairs(prev_optional_capabilities) do
     if not switch_utils.tbl_contains(optional_capabilities, capability) then
-      return false
+      return true
     end
   end
-  return true
+  return false
 end
 
 local function add_camera_subscribed_attributes(device)
@@ -566,11 +573,9 @@ local function match_profile(device, status_light_enabled_present, status_light_
     table.insert(optional_supported_component_capabilities, {component_map.doorbell, doorbell_component_capabilities})
   end
 
-  if not device:get_field(CAMERA_INITIALIZED) or
-    not compare_optional_capabilities(optional_supported_component_capabilities, device:get_field(OPTIONAL_SUPPORTED_COMPONENT_CAPABILITIES) or {}) then
+  if not device:get_field(CAMERA_INITIALIZED) or optional_capabilities_list_changed(optional_supported_component_capabilities, device.profile.components) then
     device:try_update_metadata({profile = "matter-camera", optional_component_capabilities = optional_supported_component_capabilities})
     device:set_field(CAMERA_INITIALIZED, true, {persist = true})
-    device:set_field(OPTIONAL_SUPPORTED_COMPONENT_CAPABILITIES, optional_supported_component_capabilities, {persist = true})
   end
 end