Thanks for contributing! Our community of developers is what put SmartThings on the map!
As a user of the Core SDK, you're the perfect candidate to help us improve our documentation. Error fixes, typo corrections, better explanations, more examples, etc. Open issues for things that could be improved – anything. Even improvements to this document.
We're always looking for more opinions on discussions in the issue tracker. It's a good opportunity to influence the future direction of this SDK.
- Search the issue tracker before opening an issue
- Ensure you're using the latest version
- Use a clear and descriptive title
- Include as much information as possible by filling out the issue template
- The more time you put into an issue, the more we will
- Non-trivial changes are often best discussed in an issue first, to prevent you from doing unnecessary work.
- For ambitious tasks, you should try to get your work in front of the community for feedback as soon as possible. Open a pull request as soon as you have done the minimum needed to demonstrate your idea. At this early stage, don't worry about making things perfect, or 100% complete. Describe what you still need to do and submit a draft pull request. This lets reviewers know not to nit-pick small details or point out improvements you already know you need to make.
- Don't include unrelated changes
- Pull requests should include only a single commit. You can use
git rebase -i main
to combine multiple commits into a single one if necessary. - New features should be accompanied with tests and documentation
- Commit messages
- Use a clear and descriptive title for the pull request and commits.
- Commit messages must be formatted properly using conventional commit format.
- We use changesets to automatically version and publish releases, and generate release notes. Please include one with your pull request by following the instructions to add a changeset. We have a bot that will remind you to include one with your pull request if you forget.
- This repo is commitizen friendly, so you can use the
cz
cli to help create your commits.
- Lint and test before submitting the pull request
npm run lint
npm run test
- Write a convincing description of why we should land your pull request. Answer why it's needed and provide use-cases.
- Make the pull request from a topic branch (not main)
- You might be asked to do changes to your pull request. There's never a need to open another pull request – just update the existing one.
Look at the existing issues for areas of contribution. Searching for issues labeled help wanted
would be a great place to start.
If you are not familiar with SmartThings, we have extensive on-line documentation.
To create and manage your services and devices on SmartThings, create an account in the developer workspace.
The SmartThings Community is a good place to share and ask questions.
There is also a SmartThings reddit community where you can read and share information.
Licensed under the Apache License, Version 2.0
Copyright 2023 Samsung Electronics Co., LTD.