Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misalignment which might be triggered by an actvitiy view in the default ERC20 TokenScript #382

Open
zhangzhongnan928 opened this issue Aug 24, 2020 · 2 comments
Assignees

Comments

@zhangzhongnan928
Copy link
Member

zhangzhongnan928 commented Aug 24, 2020

I think the views need to be tweaked. Eg. format the token values so they are 4 decimal places. The following screenshot was on iOS

Note that there is actually no ERC20 transactions between

0xca38ecae4441c36e16a9b2b3e67f9923b2f8ff4b6e36fcfc5c753644793b64e3

and

0xca38ecae4441c36e16a9b2b3e67f9923b2f8ff4b6e36fcfc5c753644793b64e3

(involving 0.000087058686687515 and 0.407994623666129863 units being transferred, respectively)

@hboon said:

The problem should also go away if we remove the views from the overriding TokenScript file if/since they look the same as the native version.

@SmartLayer SmartLayer changed the title Suggest using gitbook to manage TokenScript document misalignment which might be triggered by an actvitiy view in the default ERC20 TokenScript Sep 17, 2020
@SmartLayer
Copy link

Unrelated to, but reported by Victor together with AlphaWallet/alpha-wallet-ios#2140

@hboon
Copy link
Member

hboon commented Sep 18, 2020

misalignment which might be triggered by an actvitiy view in the default ERC20 TokenScript

Not necessary in the default ERC20 TokenScript because the iOS TokenScript engine doesn't use the activity views defined in the base ERC20 TokenScript files. It's natively rendered. There's likely a separate overriding (or from the repo) TokenScript file installed for aETH here. That's the one that should be fixed.

(At the risk of being long-winded: it might be a problem in the default ERC20 TokenScript file if the aETH activity views were copied from it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants